Re: Rewrite Skyline code (issue 547980044 by address@hidden)

[hanwenn]

I'm going to put this on pause for a bit. With removing normalize() from
the list -> vector patch, this is going to be a 1% performance
deterioration, I think. I have some ideas about introducing
BuildingQueue so we can do raise and shift more efficiently, but I have
to first try it out. 


https://codereview.appspot.com/547980044/diff/572060043/lily/skyline.cc
File lily/skyline.cc (right):

https://codereview.appspot.com/547980044/diff/572060043/lily/skyline.cc#newcode175
lily/skyline.cc:175: Building front_;
On 2020/04/27 07:01:28, hahnjo wrote:
> In any case, this causes copies on every call to next(). If you need
to retain
> this data structure, is there a reason not to use a pointer to the
current
> element? AFAICS you don't modify the underlying vector when using a
> BuildingQueue

see the split_off() function.

https://codereview.appspot.com/547980044/