|
From: | barrykp |
Subject: | Re: Issue 4182: avoid checking the offset of cross-staff stems too early (issue 554030043 by address@hidden) |
Date: | Fri, 08 May 2020 00:30:27 -0700 |
Thank you for looking at this! Issues should be fixed. https://codereview.appspot.com/554030043/diff/582040043/input/regression/cross-staff-stem-offset.ly File input/regression/cross-staff-stem-offset.ly (right): https://codereview.appspot.com/554030043/diff/582040043/input/regression/cross-staff-stem-offset.ly#newcode5 input/regression/cross-staff-stem-offset.ly:5: Cross-staff stems should not have their @code{'X-offset} calculated too On 2020/05/07 20:37:38, lemzwerg wrote: > We normally don't use the "'" symbol in documentation. Done. https://codereview.appspot.com/554030043/diff/582040043/input/regression/cross-staff-stem-offset.ly#newcode6 input/regression/cross-staff-stem-offset.ly:6: early because @code{'direction} may not be known. The last stem in this On 2020/05/07 20:37:38, lemzwerg wrote: > Please use two spaces after a full stop. Done. https://codereview.appspot.com/554030043/
[Prev in Thread] | Current Thread | [Next in Thread] |