[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Split glyph contours in up/down segments for skylines (issue 5697000
From: |
Han-Wen Nienhuys |
Subject: |
Re: Split glyph contours in up/down segments for skylines (issue 569700043 by address@hidden) |
Date: |
Fri, 8 May 2020 16:20:24 +0200 |
On Fri, May 8, 2020 at 4:14 PM <address@hidden> wrote:
>
> On 2020/05/08 14:03:23, hanwenn wrote:
> >
> https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode162
> > lily/freetype.cc:162: }
> > On 2020/05/08 08:15:59, hahnjo wrote:
> > > This code looks very familiar. Don't we already have it in
> > > make_draw_bezier_boxes?
> >
> > yes.
>
> So can we reuse that?
No, because there the segments don't have orientation. I also want to
use integer math at some point here, so we'd have extra work to
disentangle the code again.
> > sure. But what would we assert? FT reserves the right to put other
> things in tag
> > bits.
>
> assert(false) that none of the previous cases was true? That should
> detect a breaking change in FT_Outline pretty quickly.
I'm going to defer to Werner for advice here. Given that it was like
this before, I think it's better it as is in this change.
--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen
- Re: Split glyph contours in up/down segments for skylines (issue 569700043 by address@hidden), lemzwerg, 2020/05/01
- Re: Split glyph contours in up/down segments for skylines (issue 569700043 by address@hidden), jonas . hahnfeld, 2020/05/08
- Re: Split glyph contours in up/down segments for skylines (issue 569700043 by address@hidden), hanwenn, 2020/05/08
- Re: Split glyph contours in up/down segments for skylines (issue 569700043 by address@hidden), jonas . hahnfeld, 2020/05/08
- Re: Split glyph contours in up/down segments for skylines (issue 569700043 by address@hidden),
Han-Wen Nienhuys <=
- Re: Split glyph contours in up/down segments for skylines (issue 569700043 by address@hidden), dak, 2020/05/08
- Re: Split glyph contours in up/down segments for skylines (issue 569700043 by address@hidden), jonas . hahnfeld, 2020/05/08
- Re: Split glyph contours in up/down segments for skylines (issue 569700043 by address@hidden), lemzwerg, 2020/05/08
- Re: Split glyph contours in up/down segments for skylines (issue 569700043 by address@hidden), lemzwerg, 2020/05/08
- Re: Split glyph contours in up/down segments for skylines (issue 569700043 by address@hidden), hanwenn, 2020/05/10
- Re: Split glyph contours in up/down segments for skylines (issue 569700043 by address@hidden), jonas . hahnfeld, 2020/05/10