[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Clean up and fix glyph contour generation nits. (issue 566080043 by addr
From: |
hanwenn |
Subject: |
Clean up and fix glyph contour generation nits. (issue 566080043 by address@hidden) |
Date: |
Sat, 09 May 2020 03:36:02 -0700 |
Reviewers: lemzwerg,
Message:
Werner, can you confirm that this looks correct? I'm especially not
certain about the wrapping.
Description:
Clean up and fix glyph contour generation nits.
There are two bugs:
* Glyphs with multiple contours (e.g. "O" or "i") should compute the
contours separately
* Contours can wraparound to the start. This leads to OOB reads and/or
incorrect outlines in other circumstances.
Please review this at https://codereview.appspot.com/566080043/
Affected files (+70, -45 lines):
M lily/freetype.cc
- Clean up and fix glyph contour generation nits. (issue 566080043 by address@hidden),
hanwenn <=
- Re: Clean up and fix glyph contour generation nits. (issue 566080043 by address@hidden), lemzwerg, 2020/05/09
- Re: Clean up and fix glyph contour generation nits. (issue 566080043 by address@hidden), jonas . hahnfeld, 2020/05/09
- Re: Clean up and fix glyph contour generation nits. (issue 566080043 by address@hidden), hanwenn, 2020/05/09
- Re: Clean up and fix glyph contour generation nits. (issue 566080043 by address@hidden), hanwenn, 2020/05/09
- Re: Clean up and fix glyph contour generation nits. (issue 566080043 by address@hidden), lemzwerg, 2020/05/10
- Re: Clean up and fix glyph contour generation nits. (issue 566080043 by address@hidden), jonas . hahnfeld, 2020/05/10
- Re: Clean up and fix glyph contour generation nits. (issue 566080043 by address@hidden), jonas . hahnfeld, 2020/05/10
- Re: Clean up and fix glyph contour generation nits. (issue 566080043 by address@hidden), hanwenn, 2020/05/10
- Re: Clean up and fix glyph contour generation nits. (issue 566080043 by address@hidden), jonas . hahnfeld, 2020/05/10