[lmi-commits] (no subject)

[Greg Chicares]

branch: master
commit 23996ceac8343e69b73ee518bd9625743869e5e5
Author: Gregory W. Chicares <address@hidden>
Date:   Sat Jun 11 19:11:20 2016 +0000

    Remove spreadsheet file extension from Preferences dialog
    
    It seemed like a good idea to add this to the dialog when other fields
    were being added, even though it's hard to imagine any end user wanting
    to change it. However, two problems were observed in testing. The minor
    problem was that the leading dot might be removed, resulting in
      my_reporttsv
               ^ missing dot
    and a special workaround seemed unjustified in light of the feature's
    lack of usefulness. The major problem was that most end users have a
    proprietary spreadsheet program that opens the TSV files lmi creates
    seemlessly if its former default extension, '.xls', is used, but fails
    if its new default, '.xlsx', is used instead. Thus, the most obvious
    extension that would occur to end users would break something that has
    worked for decades, so no choice should be offered at all in the GUI.
    The cognoscenti prefer '.gnumeric', but know how to edit xml by hand
    and need no GUI.
---
 preferences_model.cpp |    3 ---
 preferences_model.hpp |    1 -
 preferences_view.xrc  |   13 -------------
 3 files changed, 17 deletions(-)

diff --git a/preferences_model.cpp b/preferences_model.cpp
index e0e29e6..e560c89 100644
--- a/preferences_model.cpp
+++ b/preferences_model.cpp
@@ -76,7 +76,6 @@ void PreferencesModel::AscribeMembers()
     ascribe("PrintDirectory"                , 
&PreferencesModel::PrintDirectory                );
     ascribe("SecondsToPauseBetweenPrintouts", 
&PreferencesModel::SecondsToPauseBetweenPrintouts);
     ascribe("SkinFileName"                  , &PreferencesModel::SkinFileName  
                );
-    ascribe("SpreadsheetFileExtension"      , 
&PreferencesModel::SpreadsheetFileExtension      );
     ascribe("UseBuiltinCalculationSummary"  , 
&PreferencesModel::UseBuiltinCalculationSummary  );
 }
 
@@ -235,7 +234,6 @@ void PreferencesModel::Load()
     PrintDirectory                 = z.print_directory();
     SecondsToPauseBetweenPrintouts = z.seconds_to_pause_between_printouts();
     SkinFileName                   = z.skin_filename();
-    SpreadsheetFileExtension       = z.spreadsheet_file_extension();
     UseBuiltinCalculationSummary   = z.use_builtin_calculation_summary() ? 
"Yes" : "No";
 }
 
@@ -267,7 +265,6 @@ void PreferencesModel::Save() const
     z["print_directory"                   ] = PrintDirectory          .value();
     z["seconds_to_pause_between_printouts"] = 
value_cast<std::string>(SecondsToPauseBetweenPrintouts.value());
     z["skin_filename"                     ] = SkinFileName            .value();
-    z["spreadsheet_file_extension"        ] = SpreadsheetFileExtension.value();
     z["use_builtin_calculation_summary"   ] = value_cast<std::string>("Yes" == 
UseBuiltinCalculationSummary);
 }
 
diff --git a/preferences_model.hpp b/preferences_model.hpp
index 7830e80..f703f23 100644
--- a/preferences_model.hpp
+++ b/preferences_model.hpp
@@ -85,7 +85,6 @@ class LMI_SO PreferencesModel
     datum_string            PrintDirectory;
     tnr_nonnegative_integer SecondsToPauseBetweenPrintouts;
     ce_skin_name            SkinFileName;
-    datum_string            SpreadsheetFileExtension;
     mce_yes_or_no           UseBuiltinCalculationSummary;
 };
 
diff --git a/preferences_view.xrc b/preferences_view.xrc
index 2a4078d..5722a57 100644
--- a/preferences_view.xrc
+++ b/preferences_view.xrc
@@ -289,19 +289,6 @@
                         <help>Number of seconds to pause between batched 
printouts, to prevent the printer from scrambling their order</help>
                     </object>
                 </object>
-                <object class="sizeritem">
-                    <flag>wxALIGN_RIGHT|wxALIGN_CENTER_VERTICAL|wxRIGHT</flag>
-                    <border>4</border>
-                    <object class="wxStaticText">
-                        <label>Spreadsheet file extension</label>
-                    </object>
-                </object>
-                <object class="sizeritem">
-                    <flag>wxGROW</flag>
-                    <object class="wxTextCtrl" name="SpreadsheetFileExtension">
-                        <help>File extension for spreadsheet output</help>
-                    </object>
-                </object>
             </object>
         </object>
     </object>