[lmi-commits] [lmi] master 89c8cc5 2/9: Use forward declarations to improve physical design

[Greg Chicares]

branch: master
commit 89c8cc539e82e3da737219b86fe3cc3faf043152
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Use forward declarations to improve physical design
    
    * datum_base.hpp: <iosfwd> suffices because the inserter and extractor
    don't use operator<<() or operator>>() from ns std.
    
    * datum_boolean.cpp: <istream> and <ostream> required to use inserter
    and extractor defined in ns std.
    * datum_string.cpp: ditto.
    * mc_enum.tpp: ditto.
    
    * ncnnnpnn.hpp: Including <istream> was just a mistake.
---
 datum_base.hpp    | 3 +--
 datum_boolean.cpp | 3 +++
 datum_string.cpp  | 3 +++
 mc_enum.tpp       | 2 ++
 ncnnnpnn.hpp      | 1 -
 5 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/datum_base.hpp b/datum_base.hpp
index 838aa0d..8caa34a 100644
--- a/datum_base.hpp
+++ b/datum_base.hpp
@@ -26,8 +26,7 @@
 
 #include "so_attributes.hpp"
 
-#include <istream>
-#include <ostream>
+#include <iosfwd>
 
 // Implicitly-declared special member functions do the right thing.
 
diff --git a/datum_boolean.cpp b/datum_boolean.cpp
index 9f64847..3a0f310 100644
--- a/datum_boolean.cpp
+++ b/datum_boolean.cpp
@@ -23,6 +23,9 @@
 
 #include "datum_boolean.hpp"
 
+#include <istream>
+#include <ostream>
+
 datum_boolean::datum_boolean(bool value)
     :value_ {value}
 {
diff --git a/datum_string.cpp b/datum_string.cpp
index 7342a3e..8f42d62 100644
--- a/datum_string.cpp
+++ b/datum_string.cpp
@@ -25,6 +25,9 @@
 
 #include "facets.hpp"
 
+#include <istream>
+#include <ostream>
+
 datum_string::datum_string(std::string const& value)
     :value_ {value}
 {
diff --git a/mc_enum.tpp b/mc_enum.tpp
index 1b665c8..d4a9b9a 100644
--- a/mc_enum.tpp
+++ b/mc_enum.tpp
@@ -28,6 +28,8 @@
 #include "rtti_lmi.hpp"
 
 #include <algorithm>                    // find()
+#include <istream>
+#include <ostream>
 #include <typeinfo>
 
 /// The header that defines class mc_enum is by design unaware of its
diff --git a/ncnnnpnn.hpp b/ncnnnpnn.hpp
index 7928b2b..c51429e 100644
--- a/ncnnnpnn.hpp
+++ b/ncnnnpnn.hpp
@@ -30,7 +30,6 @@
 
 #include <iomanip>
 #include <ios>
-#include <istream>
 #include <sstream>
 #include <stdexcept>
 #include <string>