[lmi-commits] [lmi] master db9783b 01/13: Document some ideas for future improvements

[Greg Chicares]

branch: master
commit db9783bbdd71388a4238c59725f86166d8c64b7c
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Document some ideas for future improvements
---
 interest_rates.cpp        | 12 ++++++++++++
 mortality_rates_fetch.cpp |  9 +++++++++
 2 files changed, 21 insertions(+)

diff --git a/interest_rates.cpp b/interest_rates.cpp
index 9653ecd..860adc8 100644
--- a/interest_rates.cpp
+++ b/interest_rates.cpp
@@ -249,6 +249,18 @@ bool need_loan_rates(yare_input const& yi)
 #endif // 0
 } // Unnamed namespace.
 
+#if 0
+instead of passing BasicValues, pass these requirements only:
+    v.yare_input_
+    v.database()
+    v.InvestmentManagementFee()
+    v.GetLength()
+    v.round_interest_rate()
+    v.round_interest_rate_7702()
+    v.IsSubjectToIllustrationReg()
+    v.SpreadFor7702()
+#endif // 0
+
 InterestRates::InterestRates(BasicValues const& v)
     :Length_             {v.GetLength()}
     ,RoundIntRate_       {v.round_interest_rate()}
diff --git a/mortality_rates_fetch.cpp b/mortality_rates_fetch.cpp
index 6139007..b9c6e91 100644
--- a/mortality_rates_fetch.cpp
+++ b/mortality_rates_fetch.cpp
@@ -37,6 +37,15 @@
 // Mortality tables are read in class BasicValues, then used here.
 // The vectors are used by value, not by reference, so they are
 // copied needlessly. Tables should instead be read here.
+//
+// Instead of exposing class BasicValues here, it would be better to
+// pass only the required subset of data:
+//  basic_values.GetIssueAge()
+//  basic_values.GetLength()
+//  basic_values.database()
+//  basic_values.yare_input_
+//  basic_values.round_coi_rate()
+//  basic_values.GetGuarCOIRates() etc.
 
 //============================================================================
 void MortalityRates::fetch_parameters(BasicValues const& basic_values)