[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] odd/transcend 1017bcb 2/3: Expunge temporary validat
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] odd/transcend 1017bcb 2/3: Expunge temporary validating assertion |
Date: |
Thu, 28 Jan 2021 13:14:51 -0500 (EST) |
branch: odd/transcend
commit 1017bcb08614a2db81d5fe9541a989a2ea67b23f
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Expunge temporary validating assertion
'Speed_*' files show the speedup due to the preceding commit (without
its temporary assertion, which was intended only for acceptance testing
and has been removed in this commit): maybe one percent for i386-msw,
two for x86_64-msw, and eight for x86_64 pc-linux-gnu; but much less
for the no-solve scenario, which runs the (now faster) monthiversary
loop only once, allowing overhead to dominate.
Cf.:
https://lists.nongnu.org/archive/html/lmi/2020-10/msg00029.html
| "lmi spends one-twelfth of its time in expm1()...for pc-linux-gnu"
---
Speed_gcc_i686-w64-mingw32 | 12 ++++++------
Speed_gcc_x86_64-pc-linux-gnu | 12 ++++++------
Speed_gcc_x86_64-w64-mingw32 | 12 ++++++------
ihs_avmly.cpp | 13 -------------
4 files changed, 18 insertions(+), 31 deletions(-)
diff --git a/Speed_gcc_i686-w64-mingw32 b/Speed_gcc_i686-w64-mingw32
index ec20225..0cfb2f4 100644
--- a/Speed_gcc_i686-w64-mingw32
+++ b/Speed_gcc_i686-w64-mingw32
@@ -1,7 +1,7 @@
Test speed:
- naic, no solve : 6.140e-02 s mean; 60962 us least of 17 runs
- naic, specamt solve : 1.087e-01 s mean; 107801 us least of 10 runs
- naic, ee prem solve : 9.953e-02 s mean; 98685 us least of 11 runs
- finra, no solve : 2.308e-02 s mean; 22885 us least of 44 runs
- finra, specamt solve: 6.607e-02 s mean; 65418 us least of 16 runs
- finra, ee prem solve: 6.131e-02 s mean; 60856 us least of 17 runs
+ naic, no solve : 6.048e-02 s mean; 60178 us least of 17 runs
+ naic, specamt solve : 1.072e-01 s mean; 106689 us least of 10 runs
+ naic, ee prem solve : 9.806e-02 s mean; 97641 us least of 11 runs
+ finra, no solve : 2.324e-02 s mean; 23054 us least of 44 runs
+ finra, specamt solve: 6.564e-02 s mean; 65262 us least of 16 runs
+ finra, ee prem solve: 6.320e-02 s mean; 60415 us least of 16 runs
diff --git a/Speed_gcc_x86_64-pc-linux-gnu b/Speed_gcc_x86_64-pc-linux-gnu
index 7255cdc..fcc2242 100644
--- a/Speed_gcc_x86_64-pc-linux-gnu
+++ b/Speed_gcc_x86_64-pc-linux-gnu
@@ -1,7 +1,7 @@
Test speed:
- naic, no solve : 2.519e-02 s mean; 24940 us least of 40 runs
- naic, specamt solve : 4.382e-02 s mean; 43197 us least of 23 runs
- naic, ee prem solve : 4.004e-02 s mean; 39716 us least of 25 runs
- finra, no solve : 8.380e-03 s mean; 8012 us least of 100 runs
- finra, specamt solve: 2.515e-02 s mean; 24774 us least of 40 runs
- finra, ee prem solve: 2.347e-02 s mean; 22908 us least of 43 runs
+ naic, no solve : 2.303e-02 s mean; 22433 us least of 44 runs
+ naic, specamt solve : 3.961e-02 s mean; 39256 us least of 26 runs
+ naic, ee prem solve : 3.622e-02 s mean; 35800 us least of 28 runs
+ finra, no solve : 8.234e-03 s mean; 7796 us least of 100 runs
+ finra, specamt solve: 2.348e-02 s mean; 22718 us least of 43 runs
+ finra, ee prem solve: 2.268e-02 s mean; 21205 us least of 45 runs
diff --git a/Speed_gcc_x86_64-w64-mingw32 b/Speed_gcc_x86_64-w64-mingw32
index 172e656..ea463e1 100644
--- a/Speed_gcc_x86_64-w64-mingw32
+++ b/Speed_gcc_x86_64-w64-mingw32
@@ -1,7 +1,7 @@
Test speed:
- naic, no solve : 3.386e-02 s mean; 33629 us least of 30 runs
- naic, specamt solve : 5.437e-02 s mean; 54066 us least of 19 runs
- naic, ee prem solve : 5.036e-02 s mean; 50030 us least of 20 runs
- finra, no solve : 1.630e-02 s mean; 15494 us least of 62 runs
- finra, specamt solve: 3.428e-02 s mean; 34090 us least of 30 runs
- finra, ee prem solve: 3.225e-02 s mean; 32052 us least of 32 runs
+ naic, no solve : 3.308e-02 s mean; 32862 us least of 31 runs
+ naic, specamt solve : 5.486e-02 s mean; 52738 us least of 19 runs
+ naic, ee prem solve : 4.899e-02 s mean; 48709 us least of 21 runs
+ finra, no solve : 1.565e-02 s mean; 15412 us least of 64 runs
+ finra, specamt solve: 3.382e-02 s mean; 33490 us least of 30 runs
+ finra, ee prem solve: 3.184e-02 s mean; 31464 us least of 32 runs
diff --git a/ihs_avmly.cpp b/ihs_avmly.cpp
index 21a5d8d..cd7807b 100644
--- a/ihs_avmly.cpp
+++ b/ihs_avmly.cpp
@@ -2189,19 +2189,6 @@ void AccountValue::TxCreditInt()
currency notional_sep_acct_charge = C0;
- { // Temporary validating assertion.
- // SOMEDAY !! This should be done in the interest-rate class.
- double gross_sep_acct_rate = i_upper_12_over_12_from_i<double>()
- (InterestRates_->SepAcctGrossRate(SepBasis_)[Year]
- );
- gross_sep_acct_rate = round_interest_rate()(gross_sep_acct_rate);
- if(mce_gen_mdpt == GenBasis_)
- {
- gross_sep_acct_rate = 0.0;
- }
- LMI_ASSERT(gross_sep_acct_rate == YearsSepAcctGrossRate);
- }
-
if(C0 < AVSepAcct)
{
SepAcctIntCred = InterestCredited(AVSepAcct, YearsSepAcctIntRate);