[lmi-commits] [lmi] master 79fd114c 4/4: Remove deceptive sediment

[Greg Chicares]

branch: master
commit 79fd114c44f16ed8a8add9d03131fac90f38bade
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Remove deceptive sediment
    
    Routine post-commit review of SHA1 925e5fb6759d discovered an apparent
    anomaly in the revision of 'msw_generic.make': it used $(EXEEXT) in an
    immediately-expanded (":=") makefile variable, before $(EXEEXT) was
    defined by including 'msw_common.make'. Experimentation showed that
    $(EXEEXT) already had the intended value '.exe', so the (re)definition
    in 'msw_common.make' was unnecessary and confusing. Analysis:
      git grep '\(EXEEXT\|PERFORM\)[ :]*='
    showed that both $(EXEEXT) and $(PERFORM) were already set by
    '*toolchain.sh', and that those scripts are necessary and sufficient.
    Accordingly, removed the redundant redefinitions to avoid confusion.
    
    It may at first seem surprising that $(EXEEXT) and $(SHREXT) are
    treated differently because, superficially, they seem so similar.
    However, $(SHREXT) is merely a build-time convention, whereas $(EXEEXT)
    is a requirement for running any msw program under wine-7, even during
    a build.
---
 msw_common.make | 3 ---
 posix_fhs.make  | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/msw_common.make b/msw_common.make
index bff2510f..d9edfef4 100644
--- a/msw_common.make
+++ b/msw_common.make
@@ -21,11 +21,8 @@
 
 
################################################################################
 
-EXEEXT := .exe
 SHREXT := .dll
 
-################################################################################
-
 # Libraries and associated options.
 
 # There is no universal standard way to install free software on this
diff --git a/posix_fhs.make b/posix_fhs.make
index 21c9394b..fac0c24b 100644
--- a/posix_fhs.make
+++ b/posix_fhs.make
@@ -23,11 +23,8 @@
 
################################################################################
 
 system_root := /
-EXEEXT :=
 SHREXT := .so
 
-PERFORM :=
-
 EXTRA_LIBS := -ldw -lunwind -ldl
 
 AR      := ar