[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 876d4b5b 8/8: Remove unhelpful defect markers
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 876d4b5b 8/8: Remove unhelpful defect markers [265] |
Date: |
Fri, 17 Jun 2022 17:16:28 -0400 (EDT) |
branch: master
commit 876d4b5b8ab54169bc36c0cbd91a48bfa6742322
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Remove unhelpful defect markers [265]
This is just an auxiliary tool for developers to use for the analysis
of system-test regressions. These possible shortcomings were noted in
the previous century, and if they mattered much, they'd have been
addressed by now. They certainly aren't defects of lmi per se.
---
ihs_crc_comp.cpp | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/ihs_crc_comp.cpp b/ihs_crc_comp.cpp
index a2e85133..68ecccd0 100644
--- a/ihs_crc_comp.cpp
+++ b/ihs_crc_comp.cpp
@@ -53,14 +53,14 @@
//
// [1] "crc": zero-based index of cell, whitespace, 32-bit CRC
// the composite is defined to have index -1
-// regexp: ^[-0-9][0-9]*[ \t][-0-9][0-9]*$ TODO ?? Right?
+// regexp: ^[-0-9][0-9]*[ \t][-0-9][0-9]*$
// sed -e'/^[-0-9][0-9]*[[:blank:]][-0-9][0-9]*$/!d'
// examples:
// 0 2753575139
// -1 1560388799
//
// [2] "name": name of a composite yearly variable
-// regexp: ^[A-Za-z][0-9A-Za-z]*$ TODO ?? Right?
+// regexp: ^[A-Za-z][0-9A-Za-z]*$
// example:
// EeGrossPmt
// except that this regexp would also get the following values:
@@ -82,7 +82,7 @@ std::vector<std::string> const& get_special_type_3_not_2()
// which are yearly elements instead. No other yearly quantity has
// a non-numeric value at this time.
//
-// TODO ?? It would be more maintainable to include enums.hpp here, but
+// It would be more maintainable to include enumerations here, but
// that would force us to compile other .cpp files and link their
// object code. For now at least, I've chosen the straightforward
// approach.
@@ -124,7 +124,7 @@ bool const transition_matrix[6][6] =
/* to: 0 1 2 3 4 5 */
/* from 0 */ {0, 1, 1, 0, 0, 0,},
/* from 1 */ {0, 1, 1, 0, 0, 0,},
- /* from 2 */ {0, 0, 1, 1, 1, 1,}, // TODO ?? Think about 2 -> 2,4 some
more.
+ /* from 2 */ {0, 0, 1, 1, 1, 1,}, // SOMEDAY !! Think about 2 -> 2,4
some more.
/* from 3 */ {0, 0, 1, 1, 1, 0,},
/* from 4 */ {0, 0, 1, 0, 1, 0,},
/* from 5 */ {0, 0, 0, 0, 0, 0,},
@@ -228,7 +228,7 @@ void f_2(std::string const& line1, std::string const& line2)
{
if
( line1 != line2
-// TODO ?? Fix this kludge, which strives to ignore fund names.
+// SOMEDAY !! Fix this kludge, which strives to ignore fund names.
&& contains(line1, " ")
)
{
@@ -259,7 +259,7 @@ void f12(std::string const& line1, std::string const& line2)
}
//============================================================================
-// TODO ?? Think about this one some more.
+// SOMEDAY !! Think about this one some more.
void f22(std::string const& line1, std::string const& line2)
{
f_2(line1, line2);
@@ -416,7 +416,7 @@ int try_main(int argc, char* argv[])
max_abs_diff = 0.0L;
max_rel_err = 0.0L;
- // TODO ?? Want different things that match no type.
+ // Want different things that match no type.
std::string line1 = "";
std::string line2 = "";
- [lmi-commits] [lmi] master updated (7d0257a3 -> 876d4b5b), Greg Chicares, 2022/06/17
- [lmi-commits] [lmi] master bcd3e721 2/8: Make relative-error function generally available, Greg Chicares, 2022/06/17
- [lmi-commits] [lmi] master ac211c61 7/8: Write DECIMAL_DIG where it's obviously intended, Greg Chicares, 2022/06/17
- [lmi-commits] [lmi] master 876d4b5b 8/8: Remove unhelpful defect markers [265],
Greg Chicares <=
- [lmi-commits] [lmi] master 79298e8c 1/8: Avoid left shift of a negative signed integer in fdlibm, Greg Chicares, 2022/06/17
- [lmi-commits] [lmi] master 08ec6337 4/8: Genericize relative_error(), Greg Chicares, 2022/06/17
- [lmi-commits] [lmi] master 4eb11e23 5/8: Use relative_error, Greg Chicares, 2022/06/17
- [lmi-commits] [lmi] master 8dfc0348 6/8: Remove an obsolete comment, Greg Chicares, 2022/06/17
- [lmi-commits] [lmi] master 0c922cb6 3/8: Rename rel_err() --> relative_error(), Greg Chicares, 2022/06/17