[lmi-commits] [lmi] master e35ff020 7/8: Suggest a workaround for a potential problem

[Greg Chicares]

branch: master
commit e35ff0205b5653de821df975c4350d6ba3203b64
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Suggest a workaround for a potential problem
    
    Overriding $(test_dir) in a command such as this:
      make $coefficiency test_dir=/opt/lmi/test_clang system_test
    causes an (empty) directory to be created, which leads to failure with
    a "No testdecks" message.
    
    Elaborated that message, suggesting a (manual) workaround.
    
    Alternative not pursued: instead of echoing a command, run it. That
    would not always be correct: the test and touchstone directories may
    deliberately contain different sets of files, or different versions of
    the same files. This problem occurs rarely, and only when $(test_dir)
    is deliberately overridden; but there may be no reason ever to do that,
    because all architectures supported now, or soon:
      LMI_COMPILER=gcc   ; LMI_TRIPLET=x86_64-pc-linux-gnu
      LMI_COMPILER=clang ; LMI_TRIPLET=x86_64-pc-linux-gnu
      LMI_COMPILER=gcc   ; LMI_TRIPLET=x86_64-w64-mingw32
    produce exactly the same output for all 1485 tests.
---
 workhorse.make | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/workhorse.make b/workhorse.make
index e692c6a5..1c679413 100644
--- a/workhorse.make
+++ b/workhorse.make
@@ -974,7 +974,12 @@ $(testdecks):
 system_test: $(datadir)/configurable_settings.xml $(touchstone_md5sums) install
        @$(ECHO) System test:
        @$(RM) --force $(addprefix $(test_dir)/*., $(test_result_suffixes))
-       @[ "$(strip $(testdecks))" != "" ] || ( $(ECHO) No testdecks. && false )
+       @[ "$(strip $(testdecks))" != "" ] \
+         || ( \
+            $(ECHO) "No testdecks. Do something like this:\\n \
+            cp -aiu $(touchstone_dir)/*.{cns,ill,ini,inix,mec,gpt} 
$(test_dir)" \
+            && false \
+            )
        @testdecks=`$(LS) --sort=size $(testdecks) || $(ECHO) $(testdecks)` \
          && $(MAKE) --file=$(this_makefile) --directory=$(test_dir) $$testdecks
        @$(SORT) --output=$(system_test_analysis) $(system_test_analysis)