Re: [Ltib] [PATCH] Dillo2 Web Browser

[Stuart Hughes]

Hi Alan,

I'm making progress.  But I have a question, please see inline (snipped 
back).

Alan Carvalho de Assis wrote:
> Hi Stuart,
>
> On 7/15/09, Stuart Hughes <address@hidden> wrote:
> > Hi Alan,

> > > There is a issue on "htons(S->port)" when converting the port value to
> > > big endian:
> > >
> > > http.c: In function 'a_Http_dns_cb':
> > > http.c:353: error: invalid 'asm': invalid operand for code 'w'
> > >
> > > I found other people getting similar issue, but failed to fix it.
> > >
> > > Then I used a solution found at here:
> > > https://www.rocklinux.net/submaster/index.websplb?mode=patch&uid=2008101217562118489
> > >
> > > This fix will limit Dillo to open only web pages on port 80 :-/
> > A proper fix for this is really needed.  Your patch would cause dillo to
> > fail on little endian (that is removing htons).  Maybe adding
> > parenthesis would work?  I think the issue is that htons is defined as
> > an assembler macro and for some reason causes an exception.
>
> I am using ARM on default endian (little endian), in fact it will not
> fail because I leaved "htons(DILLO_URL_HTTP_PORT);"
>
> I think it is failing because "->" in "htons(S->port)".
>
> > See if you can find anything, if not I'll take a look when I try to
> > apply all this.
>
> I will try parenthesis and let you know.

Which arm compiler causes the error? I don't get any error on the imx27 
build.  The toolchain I'm using is:

$ grep TOOLCHAIN config/platform/imx27ads/.config
CONFIG_TOOLCHAIN_ARMEABI_GLIBC1=y
# CONFIG_TOOLCHAIN_ARMEABI_CUSTOM is not set
CONFIG_TOOLCHAIN="tc-fsl-x86lnx-armeabi-nptl-4.1.2-3.i386.rpm"
CONFIG_TOOLCHAIN_PATH="/opt/freescale/usr/local/gcc-4.1.2-glibc-2.5-nptl-3/arm-none-linux-gnueabi"
CONFIG_TOOLCHAIN_PREFIX="arm-none-linux-gnueabi-"
CONFIG_TOOLCHAIN_CFLAGS="-O2 -fsigned-char -msoft-float"

Regards, Stuart