[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master
|
From: |
Sylvain Rochet |
|
Subject: |
Re: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. STABLE-2_1_0_RELEASE-360-g6e7ea92 |
|
Date: |
Sat, 15 Feb 2020 21:03:07 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
Hi Simon,
On Sat, Feb 15, 2020 at 02:54:40PM -0500, Simon Goldschmidt wrote:
>
> ppp: fix compiling with CCP_SUPPORT=1 but MPPE_SUPPORT=0
>
> Even if that might not make much sense, it still shouldn't
> result in compiler warnings.
>
> Signed-off-by: Simon Goldschmidt <address@hidden>
It's harmless doing so indeed, but the right check is to abort the
compilation if none of DEFLATE_SUPPORT, BSDCOMPRESS_SUPPORT,
PREDICTOR_SUPPORT, or MPPE_SUPPORT are set while CCP_SUPPORT is set.
(I know there are no data flow handling code for DEFLATE, BSDCOMPRESS
and PREDICTOR, so they are currently "quite" useless :p)
Sylvain
signature.asc
Description: Digital signature