[lwip-devel] [patch #6142] Fix link callback

[Jared Grubb]

URL:
  <http://savannah.nongnu.org/patch/?6142>

                 Summary: Fix link callback
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: jgrubb
            Submitted on: Monday 08/06/2007 at 08:30
                Category: None
                Priority: 3 - Low
                  Status: None
                 Privacy: Public
             Assigned to: jgrubb
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 1.3.0

    _______________________________________________________

Details:

I was doing some documentation on the link callback feature we added a few
weeks back (bug #20409), and I think the patch I made had too much code in it.
Specifically, we decided that there would be two functions:
* netif_set_link_up
* netif_set_link_down
and that we would leave it to the driver to know whether to call these
directly or call tcpip_callback with these functions as parameters.

In any case, the patch I applied had a netif_set_link_callback function and a
new variable in the netif struct. These were suggestions early in the task,
but what we agreed on at the end didn't need them... I forgot to take them out
of the patch.

I would like to remove netif_set_link_callback and the variable in netif.
netif_set_link_up/down will still be in the code. Does anyone object?




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6142>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/