[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #28917] ICMP STATS improvement
From: |
Martin Persich |
Subject: |
[lwip-devel] [bug #28917] ICMP STATS improvement |
Date: |
Tue, 16 Feb 2010 20:23:04 +0000 |
User-agent: |
Mozilla/5.0 (Windows; U; Win98; cs; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6 |
URL:
<http://savannah.nongnu.org/bugs/?28917>
Summary: ICMP STATS improvement
Project: lwIP - A Lightweight TCP/IP stack
Submitted by: persich
Submitted on: Tue 16 Feb 2010 08:23:03 PM GMT
Category: None
Severity: 3 - Normal
Item Group: Feature Request
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
Planned Release:
lwIP version: CVS Head
_______________________________________________________
Details:
During working on PING command in my application I found two small
improvement for LwIP STATS module:
1. Transmited ICMP_ECHO packet via RAW.C module isn't calculated in ICMP xmit
packets.
Is it possible to add this code in RAW.C (V1.28) - line #267 ?
#if ICMP_STATS
if(pcb->protocol==IP_PROTO_ICMP) {
ICMP_STATS_INC(icmp.xmit);
/* increase number of messages attempted to send */
snmp_inc_icmpoutmsgs();
}
#endif
err = ip_output_if (q, src_ip, ipaddr, pcb->ttl, pcb->tos, pcb->protocol,
netif);
...
2. Received ICMP_ER packet in module ICMP.C cause error counting.
Adding "case" in file ICMP.C (V1.50) - line #222 - solve this:
case ICMP_ER:
LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: ICMP Echo reply - type %"S16_F"
code %"S16_F" not supported.\n",
(s16_t)type, (s16_t)code));
break;
default:
...
Martin Persich
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?28917>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
- [lwip-devel] [bug #28917] ICMP STATS improvement,
Martin Persich <=