|
From: | Amir Shalem |
Subject: | [lwip-devel] [bug #34638] Dead code in tcp_receive - pcb->dupacks |
Date: | Mon, 24 Oct 2011 20:50:50 +0000 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/14.0.835.202 Safari/535.1 |
URL: <http://savannah.nongnu.org/bugs/?34638> Summary: Dead code in tcp_receive - pcb->dupacks Project: lwIP - A Lightweight TCP/IP stack Submitted by: amirshalem Submitted on: Mon 24 Oct 2011 08:50:49 PM GMT Category: TCP Severity: 3 - Normal Item Group: Faulty Behaviour Status: None Privacy: Public Assigned to: None Open/Closed: Open Discussion Lock: Any Planned Release: lwIP version: CVS Head _______________________________________________________ Details: In tcp_receive() function, line 941 http://git.savannah.gnu.org/cgit/lwip.git/tree/src/core/tcp_in.c#n941 there is dead code (new gcc yelled about it): if (pcb->dupacks + 1 > pcb->dupacks) ++pcb->dupacks; as I don't understand the code around it yet I don't offer a patch also. doesn't anybody knows whats the correct code? thanks, amir. _______________________________________________________ Reply to this item at: <http://savannah.nongnu.org/bugs/?34638> _______________________________________________ Message sent via/by Savannah http://savannah.nongnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |