[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #34669] Inverted byte order in TCP_BUILD_MSS_OPTION
From: |
Simon Goldschmidt |
Subject: |
[lwip-devel] [bug #34669] Inverted byte order in TCP_BUILD_MSS_OPTION |
Date: |
Fri, 28 Oct 2011 11:08:52 +0000 |
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1 |
Update of bug #34669 (project lwip):
Status: None => Need Info
_______________________________________________________
Follow-up Comment #2:
> Can anyone verify that this is wrong in the current code?
> I find it hard to believe that this wouldn't have been noticed before now.
When running the win32 simulation, wireshark decodes "MSS=1024" for
TCP_MSS=1024, which looks right to me (the bytes do match the order in the png
attached to the OP). And since the TCP_BUILD_MSS_OPTION define uses htonl(), I
would have expected this to work both on little- and big-endian platforms.
Andrea, could you please provide a wireshark-screenshot of a faulty connection
from lwIP that shows us what you think is wrong?
> the MSS value is never changed, the packet option will result
> always with the default value of 536 defined into TCP_MSS define
This has been fixed in git exactly 10 days ago (reported as bug #34587). The
macro now uses pcb->mss instead of TCP_MSS.
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?34669>
_______________________________________________
Nachricht geschickt von/durch Savannah
http://savannah.nongnu.org/