lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9384] Partial SACK (RFC 2018) support


From: Jakub Schmidtke
Subject: [lwip-devel] [patch #9384] Partial SACK (RFC 2018) support
Date: Mon, 3 Jul 2017 15:39:35 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36

Follow-up Comment #28, patch #9384 (project lwip):

Also, it looks like the cleanup changes are broken.
LWIP_TCP_SACK_VALID is reversed (it should be checking whether left !=
right).
It's also used wrong in tcp_in.c: if (!LWIP_TCP_SACK_VALID(pcb, 0)) - this
should be reversed. The other uses are correct (once the macro itself is
fixed).

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9384>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]