[lwip-devel] [bug #51531] getsockopt/SO_ERROR not returning value stored in errno

[Joel Cunningham]

Update of bug #51531 (project lwip):

                  Status:                   Fixed => None                   
             Assigned to:               goldsimon => None                   
             Open/Closed:                  Closed => Open                   

    _______________________________________________________

Follow-up Comment #5:

> I've just added this to UPGRADING.

Great thanks!

> Hmm, I never thought of socket application being tailored to lwIP's
implementation of the standard. We're trying to implement the standard
behaviour as documented at opengroup.org. The behaviour was wrong before (and
yes, it was easier fixing an old bug doing it the right way :-) 

I had some old application code that was written for a platform where
LWIP_SOCKET_SET_ERRNO was set to FALSE (due to platform issues with errno not
being thread safe) and thus it used getsockopt with SO_ERROR in all the places
you would normally check errno.  As we've determined, the old behavior of
SO_ERROR was wrong, but it did enable a use case where applications could use
sockets without errno support.

Maybe we need to remove LWIP_SOCKET_SET_ERRNO since you can no longer get
those errors via SO_ERROR and we don't want to lead developers to thinking
errno is optional (for sockets layer)?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?51531>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/