[lwip-devel] [patch #9425] tcp: remove extra seg == NULL checks

[Joel Cunningham]

URL:
  <http://savannah.nongnu.org/patch/?9425>

                 Summary: tcp: remove extra seg == NULL checks
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: jcunningham
            Submitted on: Thu 03 Aug 2017 03:43:24 PM UTC
                Category: TCP
                Priority: 5 - Normal
                  Status: Need Info
                 Privacy: Public
             Assigned to: jcunningham
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

Found some duplicate if (seg == NULL) checks in tcp_output that can be
combined.  Please see attached patch.

I wanted to double check that there wasn't a reason why LWIP_DEBUGF calls with
TCP_OUTPUT_DEBUG and TCP_CWND_DEBUG were guarded by #if/#endif.  I couldn't
see any reason why since LWIP_DEBUGF is a no-op when LWIP_DEBUG is not defined



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thu 03 Aug 2017 03:43:24 PM UTC  Name:
0001-tcp-remove-extra-seg-NULL-checks.patch  Size: 3KiB   By: jcunningham

<http://savannah.nongnu.org/patch/download.php?file_id=41402>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9425>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/