[lwip-devel] [bug #51765] pcb->dupacks > 3 logic added in 90873d6 not possible

[Joel Cunningham]

URL:
  <http://savannah.nongnu.org/bugs/?51765>

                 Summary: pcb->dupacks > 3 logic added in 90873d6 not possible
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: jcunningham
            Submitted on: Wed 16 Aug 2017 01:37:49 PM UTC
                Category: TCP
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head

    _______________________________________________________

Details:

The dupacks > 3 logic added in 90873d6 is not possible to reach because the
preceding if takes the > 3 case:


if (pcb->dupacks > 3) {
 /* Inflate the congestion window, but not if it means that
     the value overflows. */
   if ((tcpwnd_size_t)(pcb->cwnd + pcb->mss) > pcb->cwnd) {
     pcb->cwnd = (tcpwnd_size_t)(pcb->cwnd + pcb->mss);
   }
} else if (pcb->dupacks >=3) {
…





    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?51765>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/