[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #54229] tcp.c, 679: extra check
From: |
Andrey Vinogradov |
Subject: |
[lwip-devel] [bug #54229] tcp.c, 679: extra check |
Date: |
Mon, 2 Jul 2018 09:06:54 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3472.3 Safari/537.36 |
URL:
<http://savannah.nongnu.org/bugs/?54229>
Summary: tcp.c, 679: extra check
Project: lwIP - A Lightweight TCP/IP stack
Submitted by: andreyvinogradov
Submitted on: Пн. 02 июля 2018 13:06:53
Category: TCP
Severity: 3 - Normal
Item Group: Compiler Warning
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
Planned Release: None
lwIP version: git head
_______________________________________________________
Details:
#if LWIP_IPV4
/* Don't propagate NULL pointer (IPv4 ANY) to subsequent functions */
if (ipaddr == NULL) {
ipaddr = IP4_ADDR_ANY;
}
#endif /* LWIP_IPV4 */
/* still need to check for ipaddr == NULL in IPv6 only case */
LWIP_ERROR("tcp_bind: invalid pcb", pcb != NULL, return ERR_ARG);
LWIP_ERROR("tcp_bind: invalid ipaddr", ipaddr != NULL, return ERR_ARG);
Probably need to put "ipaddr != NULL" check in #if !LWIP_IPV4...#endif case.
It's written in comment anyway.
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?54229>
_______________________________________________
Сообщение отправлено по Savannah
https://savannah.nongnu.org/
- [lwip-devel] [bug #54229] tcp.c, 679: extra check,
Andrey Vinogradov <=