[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #56014] The ICMPv6 Parameter Problem doesn't take the
From: |
Gao Qingshui |
Subject: |
[lwip-devel] [bug #56014] The ICMPv6 Parameter Problem doesn't take the IPv6 Header of the offending packet |
Date: |
Thu, 28 Mar 2019 00:30:03 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.86 Safari/537.36 |
URL:
<https://savannah.nongnu.org/bugs/?56014>
Summary: The ICMPv6 Parameter Problem doesn't take the IPv6
Header of the offending packet
Project: lwIP - A Lightweight TCP/IP stack
Submitted by: kevingao
Submitted on: Thu 28 Mar 2019 04:30:01 AM UTC
Category: IPv6
Severity: 3 - Normal
Item Group: Faulty Behaviour
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
Planned Release: None
lwIP version: git head
_______________________________________________________
Details:
The ICMPv6 Parameter Problem doesn't take the IPv6 Header of the offending
packet as the p->payload not point to the IP header of the orignal packet.so
before calling icmp6_send_response to sending PP back to the originator, lwip
must move the p->payload pointer back to ip header.
There was two ways to fix this issue:
1) move the p->payload pointer back to ip header in function
icmp6_param_problem
2) do this action before calling icmp6_param_problem
The 1st way is simple, but break the code style if icmpv6 related function, as
all the err message
function(icmp6_dest_unreach,icmp6_packet_too_big,icmp6_time_exceeded,icmp6_param_problem)
were in the same style and the p->payload always point to ip header.
The 2nd way is a little complex, we should modify several places, but it would
keep the code style and make the code more readable.
The attached patch file was my modification using the 2nd way, pls review.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Thu 28 Mar 2019 04:30:01 AM UTC Name:
icmpv6-parameter-problem-not-take-the-IP-header-of-the-offending-packet.patch
Size: 5KiB By: kevingao
<http://savannah.nongnu.org/bugs/download.php?file_id=46652>
_______________________________________________________
Reply to this item at:
<https://savannah.nongnu.org/bugs/?56014>
_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [lwip-devel] [bug #56014] The ICMPv6 Parameter Problem doesn't take the IPv6 Header of the offending packet,
Gao Qingshui <=