Re: lynx-dev [PATCH 2.8.3.dev6] patch that allows user to define what charsets will appear in "assumed doc chset" and "display chset" popups

[Leonid Pauzner]

14-Aug-99 17:34 Vlad Harchev wrote:
> On Sat, 14 Aug 1999, Vlad Harchev wrote:

>> On Sun, 15 Aug 1999, Leonid Pauzner wrote:
>>
>> > 12-Aug-99 06:01 Vlad Harchev wrote:
>> > Do you say several ASSUMED_..._CHOICE lines possible? Why not a list?
>> > Would this be resetted with reload_read_cfg() ?
>>
>>  Yes, several ASSUMED_ ... _CHOICE are allowed. This approach simplifies
>> parsing (so now I rely on parsing by LYReadCFG.c) and allows choices to be
>> added in the INCLUDEd files.
>>  This won't work with reload_.. (I mean all new changes to lynx.cfg will be
>> lost) - but this is easy to fix. Currently new changes will be ignored (the
>> info will be gathered, but final routine won't be called).
>>  I will fix it in the end of August (Now I have only hyphenation on my TODO
>> list).
>>[...]

>  Here is a patch that makes this lynx.cfg-reloading-safe, and fixes some
> things.

>  Best regards,
>   -Vlad

...
> diff -ru old/src/LYMain.c fixed/src/LYMain.c
> --- old/src/LYMain.c  Thu Aug 12 06:49:09 1999
> +++ fixed/src/LYMain.c        Sat Aug 14 12:34:42 1999
> @@ -2105,6 +2105,10 @@
>       StrAllocCopy(LYCookieFile_flag, LYCookieFile);
>  #endif

> +#ifndef ALL_CHSETS_IN_O_SCREEN
> +      custom_assumed_doc_chset = custom_display_chset = FALSE;
> +      
> memset((char*)chset_selectability_info,0,sizeof(chset_selectability_info_t)*MAXCHARSETS);
> +#endif
>       free_lynx_cfg(); /* free downloaders, printers, not always environments 
> */
>       /*
>        *  Process the configuration file.
> @@ -2116,6 +2120,9 @@
>        */
>       read_rc();

> +#ifndef ALL_CHSETS_IN_O_SCREEN
> +     init_selectable_chsets_lists();
> +#endif

Hmm... could this be implemented via lists
like downloaders and printers in LYReadCFG.c ?

Also, how about unifying things a bit?
No lynx code knows about two diffrent options menu
except LYOptions.c and LYK_OPTION in mainloop).
Since you want to only mask the output in options menu
most of new code should belong to LYOptions.c, isn't it?
Or you want disabling them completely e.g. when reading .lynxrc etc.?
Do you change charset numbers (see forms-based options menu in '/' source)
or just mask them?

>       /* We are not interested in startfile here */
>       /* but other things may be lost: */
> diff -ru old/src/LYReadCFG.c fixed/src/LYReadCFG.c
> --- old/src/LYReadCFG.c       Thu Aug 12 05:11:27 1999
> +++ fixed/src/LYReadCFG.c     Sat Aug 14 12:30:44 1999
> @@ -974,7 +974,7 @@
>       CTRACE(tfp," - EMPTY STRING\n");
>       return 1;
>      };
> -    if (!strcasecmp(p,"<ALL>")) {
> +    if (*p=='*' && len==1) {
>       if (display_chset)
>           for (custom_display_chset=TRUE,i=0;i<LYNumCharsets;++i)
>               chset_selectability_info[i].hide_in_display_chsets = FALSE;