[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: lynx-dev Re: reload_read_cfg() crash on DJGPP
From: |
brian j pardy |
Subject: |
Re: lynx-dev Re: reload_read_cfg() crash on DJGPP |
Date: |
Sun, 12 Dec 1999 21:27:47 -0500 |
On Mon, Dec 13, 1999, Leonid Pauzner wrote:
> 13-Dec-99 04:00 I wrote:
> > With dev.16 I have discovered a crash on DJGPP port
> > when "g lynxcfg:" and activate "RELOAD".
> > gdb backtrace shows a problem in strcmp() in reload_read_cfg(),
> > LYMain.c line:2216 (clean dev.16 version)
>
> > It happen to be an EXP_PERSISTENT_COOKIES (which is default flag now
> > in makefile.dos), our old friend...
>
> > Can Doug or somebody else on DJGPP port look into that.
> > (There is no problem on Linux so far).
>
> Uh, it was with EXP_PERSISTENT_COOKIES and PERSISTENT_COOKIES:FALSE
> which now default...
>
> The following LYMain.c passage will make LYCookieFile not allocated
> when persistent_cookies is FALSE:
[...]
> Which conflicts with
> ---------------------
>
> /* set few safe flags: */
> #ifdef EXP_PERSISTENT_COOKIES
> BOOLEAN persistent_cookies_flag = persistent_cookies;
> char * LYCookieFile_flag = NULL;
> StrAllocCopy(LYCookieFile_flag, LYCookieFile);
> #endif
>
> [...]
> #ifdef EXP_PERSISTENT_COOKIES
> /* restore old settings */
> if (persistent_cookies != persistent_cookies_flag) {
> persistent_cookies = persistent_cookies_flag;
> HTAlert(gettext("persistent cookies state will be changed in next
> session only."));
> }
> if (strcmp(LYCookieFile, LYCookieFile_flag)) {
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> StrAllocCopy(LYCookieFile, LYCookieFile_flag);
> CTRACE((tfp, "cookies file can be changed in next session only,
> restored.\n"));
> }
> FREE(LYCookieFile_flag);
> #endif
>
>
> Perhaps all "reset old settings" thing should be conditional
> with if (persistent_cookies_flag) ...
Since I'm changing this area, I'll stick a conditional around there in
my patch.
--
Writing software is more fun than working.