[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Lynx-dev] [PATCH] correction for symlink brokenness in lists
From: |
Kees Cook |
Subject: |
[Lynx-dev] [PATCH] correction for symlink brokenness in lists |
Date: |
Thu, 11 Mar 2004 23:17:03 -0800 |
Hello! Looks like behavior changed between 2.8.4 and 2.8.5 when doing
listings of local directories ("lynx .")
In 2.8.4, symlinks would be sorted based on their _destination_ file
type (symlinks to dirs go into "Subdirectories", symlinks to files go to
"Files").
It looks like during cleanups the top-level "stat" turned into an
"lstat", which breaks the S_ISDIR test that would correctly sort the
symlink into the Subdirectories list.
I have delayed the "lstat" call, and instead, use just plain "stat"
again at the top, and only do an "lstat" call once we get to determining
if the file really is a symlink or not.
Patch attached...
--
Kees Cook @outflux.net
symlinks.patch
Description: Text document
_______________________________________________
Lynx-dev mailing list
address@hidden
http://mail.gnu.org/mailman/listinfo/lynx-dev
- [Lynx-dev] [PATCH] correction for symlink brokenness in lists,
Kees Cook <=