Re: [Lynx-dev] lynx iconv for Solaris

[Thomas Dickey]

On Tue, Dec 23, 2008 at 01:11:43AM +0900, Takao Fujiwara - Tokyo S/W Center 
wrote:
 
> Solaris iconv is implemented in libc so I modified 
> CF_ARG_ENABLE(japanese-utf8) in configure.in however autoconf doesn't work. 
> AC_DEFINE() needs three
> arguments to work autoconf.
> 
> To support the return values of nl_langinfo() on Solaris, I added several 
> encodings in UCGetLYhndl_byMIME().
> 

> --- lynx2-8-6/configure.in.orig       2008-12-22 10:30:12.393958000 +0900
> +++ lynx2-8-6/configure.in    2008-12-22 13:30:27.155245000 +0900

this change is addressed in the development patches toward 2.8.7

> --- lynx2-8-6/src/UCdomap.c.orig      2008-12-22 10:38:58.096800000 +0900
> +++ lynx2-8-6/src/UCdomap.c   2008-12-22 20:19:57.052909000 +0900
> @@ -936,8 +936,8 @@ int UCTransUniCharStr(char *outbuf,
>      }
>      if (isdefault || trydefault) {
>  #ifdef EXP_JAPANESEUTF8_SUPPORT
> -     if ((strcmp(LYCharSet_UC[charset_out].MIMEname, "shift_jis") == 0) ||
> -         (strcmp(LYCharSet_UC[charset_out].MIMEname, "euc-jp") == 0)) {
> +     if (LYCharSet_UC[charset_out].codepage == 0 &&
> +         LYCharSet_UC[charset_out].codepoints == 0) {
>           iconv_t cd;
>           char str[3], *pin, *pout;
>           size_t inleft, outleft;
> @@ -952,6 +952,20 @@ int UCTransUniCharStr(char *outbuf,
>           HTSprintf0(&tocode, "%s//TRANSLIT", 
> LYCharSet_UC[charset_out].MIMEname);
>           cd = iconv_open(tocode, "UTF-16BE");
>           FREE(tocode)
> +         if (cd == (iconv_t)-1) {
> +             HTSprintf0(&tocode, "%s", LYCharSet_UC[charset_out].MIMEname);

I'm puzzled here - since TRANSLIT is less stringent, I would expect
that the check would be first made on the exact translation rather
than on the transliteration.   Any comments?

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net