[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lynx-dev] -dump/-source vrs .newsauth: bug or feature?
From: |
Thomas Dickey |
Subject: |
Re: [Lynx-dev] -dump/-source vrs .newsauth: bug or feature? |
Date: |
Sun, 10 May 2009 18:56:53 -0400 (EDT) |
On Sun, 10 May 2009, Thomas Dickey wrote:
On Sun, 10 May 2009, Thomas Dickey wrote:
Another problem with reading news is that I can
look at messages with w3m at textnews.news.cambrium.nl,
but trying the same with lynx, I can get the list of messages,
but trying to look at a specific message produces:
Network Error: connection lost
I see this too - sounds like a bug...
A quick check with strace shows me that lynx does get a valid response, and
then (for some reason...) closes the connection
4377 18:33:40 read(3, "220 0 <address@hidden>
The problem is from the SSL patch which I applied in 2001 (it just happens
that the result from reading the news article contains a rubout 255
code, which is being sign-extended to a -1, which lynx then sees as an
EOF - end of file).
Here's a fix:
--- WWW/Library/Implementation/HTNews.c 2009/01/01 17:00:01 1.58
+++ WWW/Library/Implementation/HTNews.c 2009/05/10 22:53:23
@@ -51,7 +51,7 @@
(Handle ? SSL_write(Handle, buff, size) : NETWRITE(sock, buff, size))
#define NEWS_NETCLOSE(sock) \
{ (void)NETCLOSE(sock); if (Handle) { SSL_free(Handle); Handle = NULL; }
}
-static char HTNewsGetCharacter(void);
+static int HTNewsGetCharacter(void);
#define NEXT_CHAR HTNewsGetCharacter()
#else
@@ -3044,7 +3044,7 @@
}
#ifdef USE_SSL
-static char HTNewsGetCharacter(void)
+static int HTNewsGetCharacter(void)
{
if (!Handle)
return HTGetCharacter();
--
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net