Re: [Lynx-dev] Numbering problem lynx2.8.8dev.6

[Thomas Dickey]

On Sun, 21 Nov 2010, Thomas Dickey wrote:

> On Sun, 21 Nov 2010, Doug Kaufman wrote:
>
> > On Sun, 21 Nov 2010, Thomas Dickey wrote:
> >
> > > On Sat, 20 Nov 2010, Thomas Dickey wrote:
> > >
> > > > On Sat, 20 Nov 2010, Doug Kaufman wrote:
> > > >
> > > > > I just built lynx on mingw for the first time since 2.8.7rel1. I
> > > > > built for mingw under cygwin using 2.8.8dev.6 source with Tom's
> > > > > lynx2.8.8dev.6b.patch applied. The labeling of numbering of both form
> > > > > fields and links is not correct. This applies whether links, form
> > > > > fields, or both are numbered. I first noted this on Google and Google
> > > > ...
> > > > The most likely cause is this: Lynx is maintaining two lists, which are
> > > > joined together when numbering.  When I implemented the unique-urls 
> > > > feature
> > > > (which did work for my test cases...), I had to make some changes
> > > > around the section of the logic which merges things.  (I'll see if I can
> > > > isolate it tomorrow - long day).
> > >
> > > Turns out the problem is a small set of changes I made in GridText.c to
> > > use the revised numbering from the larger change in LYList.c (actually I
> > > _recall_ working with a copy of the Options menu, but most of my attention
> > > was on the part near the end, where I'd added some hidden links, for
> > > testing...).
> >
> > Thanks for getting to the bottom of this so promptly.
>
> no problem (now all I have to do is to find a fix ;-)

This seems to work (there are 3 places where a link-number is formatted,
and the others don't appear to have a problem):

diff -u -r1.206 GridText.c
--- GridText.c  2010/11/08 09:57:30     1.206
+++ GridText.c  2010/11/22 12:55:04
@@ -10379,7 +10379,7 @@
     }
     if (fields_are_numbered() && (a->number > 0)) {
        if (HTMainText != 0) {
-           a->show_number = HTMainText->next_number++;
+           HText_findAnchorNumber(a);
        } else {
            a->show_number = a->number;
        }

I'll have a dev.6c patch in my temp directory, shortly.

--
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net