Re: [Lynx-dev] Re: Are Cookies Working Correctly in Lynx 2.8?

[Owen Leibman]

In LYCookie.c, the following code in function LYSetCookie is changed between 
2.8.7 and 2.8.8,
and I believe it is responsible for the problem.

    if ((ptr = strrchr(path, '/')) != NULL &&
        (ptr != path) &&
        ptr[1] == '\0') {
        CTrace((tfp, "discarding trailing \"/\" in request URI\n"));
        *ptr = '\0';

As coded now, it does not trim the file name after the final slash in the URL, 
which is the problem I'm seeing.
I changed it to more closely match 2.8.7:

    if ((ptr = strrchr(path, '/')) != NULL) {
       if (ptr == path) {
           *(ptr + 1) = '\0';    /* Leave a single '/' alone */
       } else {
           *ptr = '\0';
       }
    }

This indeed fixed the problem. I don't know what the next steps are (certainly 
more testing is needed), but this seems like a start.



----- Original Message ----
From: Thomas Dickey <address@hidden>
To: Stefan Caunter <address@hidden>
Cc: Keith BOWES <address@hidden>; Owen Leibman <address@hidden>; 
address@hidden
Sent: Tue, March 8, 2011 2:26:03 PM
Subject: Re: [Lynx-dev] Re: Are Cookies Working Correctly in Lynx 2.8?

On Tue, 8 Mar 2011, Stefan Caunter wrote:

> On Sun, Mar 6, 2011 at 1:51 PM, Keith BOWES <address@hidden> wrote:
>> Je 2011-Mar-05 je 23:03, Owen Leibman skribis:
>>> It also works as expected with all graphical browsers (e.g. Firefox) and 
>other
>>> text browsers (e.g. w3m).
>>
>> I'm not sure it's fair to call w3m a text browser.  It does images and
>> CSS, and perhaps JavaScript too.  Not that Lynx doesn't have its share
>> of problems, but just that w3m is a totally different class of browser.
>
> I haven't noticed any problems, and there haven't been any recent
> reports, but it's entirely possible I'm missing something here.

Some reports take a while to surface (I try to verify any that have enough 
detail to reproduce).

-- 
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net