Re: [Lzip-bug] mingw build failure

[Antonio Diaz Diaz]

Roy, JonY, Elbert, thanks for your quick and useful answers. And best 
wishes for 2013 to all. :-)

Roy Tam wrote:
> for strtoull in mingw, use _strtoui64.
> [...]
> but g++ complains there is no header about it, I think keep using
> strtoll/strtoull in C++ version will be better.
> (the function exists in MSVCRT.dll but mingw header does not have prototypes)

I think I have found the perfect solution for this; instead of using 
exotic windows functions, use the standard strtoul:

  #if defined(__MSVCRT__)
  #define strtoull std::strtoul
  #endif

This surely will work on any kind of windows system and its only effect 
is that (on 32 bit windows systems) numbers larger than 4GiB must be 
given using prefixes (16G instead of 16000000000). This does not affect 
dictionary sizes, only the less used --member-size and --volume-size.


JonY wrote:
> It should be noted that that not all mingw are equal. So, please avoid
> using __MINGW32__ to select features.

Thanks for the hint. The last thing I would want to do is breaking the 
builds that already work. :-)

__MSVCRT__ seems to work on all systems tested to date, so I see no need 
to change it.


Elbert, & Nicole Pol wrote:
> lzip-1.14-rc2........................................................
> tests completed successfully.

Excellent! I hope this is the last change affecting OS/2 that will ever 
be made.


Best regards,
Antonio.