Re: 0.24 build failure on macos

[Rui Chen]

cool, let me switch the patch to use that. Thanks!

On Tue, Oct 24, 2023 at 12:50 PM Antonio Diaz Diaz <antonio@gnu.org> wrote:

Hi Rui,

Rui Chen wrote:
> I am trying to upgrade tarlz to 0.24 for homebrew. But need some build
> patch as below for major,minor,makedev on OSX builds

Thank you very much for reporting this.

makedev, major, and minor are annoying because the POSIX pax format requires
them, but POSIX leaves them unspecified. GNU/Linux systems define them in
sys/sysmacros.h[1], while BSD systems define them in sys/types.h[2].

[1] http://manpages.ubuntu.com/manpages/focal/en/man3/minor.3.html
[2] http://man.openbsd.org/minor.3

I have added an #else clause to create.cc, decode.cc, and decode_lz.cc that
I hope fixes the problem:

create.cc:
#if !defined __FreeBSD__ && !defined __OpenBSD__ && !defined __NetBSD__ && \
     !defined __DragonFly__ && !defined __APPLE__ && !defined __OS2__
#include <sys/sysmacros.h>              // for major, minor
#else
#include <sys/types.h>                  // for major, minor
#endif

decode.cc, decode_lz.cc:
#if !defined __FreeBSD__ && !defined __OpenBSD__ && !defined __NetBSD__ && \
     !defined __DragonFly__ && !defined __APPLE__ && !defined __OS2__
#include <sys/sysmacros.h>              // for major, minor, makedev
#else
#include <sys/types.h>                  // for major, minor, makedev
#endif


Best regards,
Antonio.