Re: [Man-db-devel] [PATCH 1/2] src/tests: Allow running tests individually

[Colin Watson]

On Sat, Oct 29, 2016 at 07:23:52AM +0500, Mihail Konev wrote:
> Previously, (cd src/tests && ./man-9) would complain
> about /libtool not being found (due to a missing Makefile.am
> envvar).
> 
> Add the missing path.
> ---
>  src/tests/testlib.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/tests/testlib.sh b/src/tests/testlib.sh
> index d8fbc6ca07d3..d0ba73d4e60a 100644
> --- a/src/tests/testlib.sh
> +++ b/src/tests/testlib.sh
> @@ -15,6 +15,7 @@ init () {
>  }
>  
>  run () {
> +     abs_top_builddir=${abs_top_builddir:-$(readlink -e ../../)}
>       "$abs_top_builddir/libtool" --mode=execute \
>               -dlopen "$abs_top_builddir/lib/.libs/libman.la" \
>               -dlopen "$abs_top_builddir/libdb/.libs/libmandb.la" \

This is problematic because GNU readlink(1) isn't portable.  It's also
not clear what using it buys us here; you might as well just set the
fallback to ../.. directly rather than spending much effort making it
absolute.  But either way it's not going to work properly with
out-of-tree builds.

How about just using "make -C src/tests check TESTS=man-9"?

-- 
Colin Watson                                       address@hidden