[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Man-db-devel] [PATCH v5] man(1): Fix override dir handling
From: |
Nikola Forró |
Subject: |
Re: [Man-db-devel] [PATCH v5] man(1): Fix override dir handling |
Date: |
Mon, 09 Jan 2017 15:12:23 +0100 |
On Sat, 2017-01-07 at 02:51 +0500, Mihail Konev wrote:
> Previously, override dir was affecting only some cases
> of manpath determination.
>
> Apply it only when all paths has been gathered instead.
> (Depending on the definition of when the override dir applies,
> this might not be correct).
>
> Also look for override dir when sorting candidates.
>
> Fixes src/tests/man-9 failing when --with-override-dir=od
> is passed to ./configure.
>
> Reported-by: Nikola Forró <address@hidden>
> Tested-by: Nikola Forró <address@hidden>
> ---
> v5: Fix override dir being more important than section mismatch
> (move cand1 call so that it only has higher priority than language).
> Add tested-by line.
>
> src/man.c | 33 +++++++++++++++++++++++++++++++++
> src/manp.c | 52 +++++++++++++++++++++-------------------------------
> 2 files changed, 54 insertions(+), 31 deletions(-)
Thanks Mihail,
this version looks good to me.