[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Maposmatic-dev] [PATCH] Adding link from jobs to OpenStreetMap main
From: |
Maxime Petazzoni |
Subject: |
Re: [Maposmatic-dev] [PATCH] Adding link from jobs to OpenStreetMap main site |
Date: |
Wed, 4 Aug 2010 19:16:25 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
* Pierre Mauduit <address@hidden> [2010-08-04 18:30:34]:
> From: Pierre Mauduit <address@hidden(none)>
Please fix your user.email in .git/config
> --- a/www/maposmatic/templatetags/extratags.py
> +++ b/www/maposmatic/templatetags/extratags.py
> @@ -61,6 +61,9 @@ def job_status_to_icon_name(value, arg, autoescape=None):
> if value == 4: return 'job-cancelled'
>
> return 'job-error'
You need a newline here.
> +def valueabs(value):
> + return abs(value)
> +
>
> - {% ifnotequal job.administrative_city job.maptitle %}<h3>{{
> job.administrative_city }}</h3>{% endifnotequal %}
> + <h3>
> + {% ifnotequal job.administrative_city job.maptitle %} {{
> job.administrative_city }} - {% endifnotequal %}
> + <a href="http://www.osm.org?relation={{ job.administrative_osmid|abs
> }}">{% trans "View on OpenStreetMap" %}</a></h3>
> {% else %}
> <h3>({{ job.lat_upper_left|floatformat:3 }}, {{
> job.lon_upper_left|floatformat:3 }}) →
> - ({{ job.lat_bottom_right|floatformat:3 }}, {{
> job.lon_bottom_right|floatformat:3 }})</h3>
> + ({{ job.lat_bottom_right|floatformat:3 }}, {{
> job.lon_bottom_right|floatformat:3 }})
> + - <a href="http://www.osm.org?maxlat={{ job.lat_upper_left
> }}&maxlon={{ job.lon_bottom_right }}&minlat={{ job.lat_bottom_right
> }}&minlon={{ job.lon_upper_left }}&zoom=15">{% trans "View on
> OpenStreetMap" %}</a>
> + </h3>
> +
I'm not a big fan of the <h3> tags here.
NAK, Thanks for the contribution though!
- Maxime
--
Maxime Petazzoni <http://www.bulix.org>
``One by one, the penguins took away my sanity.''
Linux kernel and software developer at MontaVista Software
signature.asc
Description: Digital signature