Re: Porting audio.js away from jQuery (Was: Re: MediaGoblin website moved to sourcehut pages (was: TLS certificate expired for mediagoblin.org, take 2))

[Andre Jaenisch]

Hey Ben,

I've got started by replicating the repository on my private Gitea
instance. (I don't accept other accounts there, so don't look for a
sign-up page - in that sense, it is private).

Next, I ran the tests (still five failing) and branched off to tackle
the first porting in 
https://jaenis.ch/hobbies/coding/repos/ryuno-ki/mediagoblin/src/branch/refactor/port-audio-js

The intermediate changes can be seen in:
https://jaenis.ch/hobbies/coding/repos/ryuno-ki/mediagoblin/compare/712728c331ea3518b1964bbc7fcf06ff2c567064...c00d3ad053d5d0862f1b71ec126e3c9e1493967d

In order to continue on audio.js I need some assistance. The file gets
referenced in these places:

-
  extlib/sandyseventiesspeedboat/templates/mediagoblin/media_displays/audio.html
-
  
mediagoblin/plugins/archivalook/templates/archivalook/feature_displays/audio_head.html
- mediagoblin/templates/mediagoblin/media_displays/audio.html

Which of them are relevant?
How can I navigate to them?

I want to make sure to not break something, but have to have a look at
the HTML to properly port the code (there are difference between a
single element being selected vs. multiple).

My gut feeling would be to look at the templates one and ignore the
other.

For whoever is also porting: http://youmightnotneedjquery.com/ might be
helpful in the process :-)

Kind regards


André

On Fri, 20 Aug 2021 07:43:13 +1000
Ben Sturmfels <ben@sturm.com.au> wrote:

> Hi André,
> 
> We're happy to merge code from a branch on any public git service, or
> also as a patch file to the mailing list with git send-email.
> 
> You haven't missed the documentation, it just used to be on the wiki
> and I've been meaning to move it into the official docs. :)
> 
> Regards,
> Ben
> 
> On Thu, 19 Aug 2021, André Jaenisch wrote:
> 
> > Hi Ben,
> >
> > thanks for letting us know.
> >
> > I will update my local master branch on the weekend.
> >
> > It is still unclear, how changes I make will find their way
> > back into the codebase.
> > Is there documentation I missed?
> >
> > Cheers,
> >
> >
> > André
> >
> >
> > Am 19. August 2021 10:53:28 MESZ schrieb Ben Sturmfels
> > <ben@sturm.com.au>:  
> >>Hi Jgart and Andre,
> >>
> >>Just FYI, I've merged into master my changes to remove jQuery from
> >>header_dropdown.js and notifications.js. I've also been moving the
> >>relevant
> >> <script> tags to bottom of the base.html template.
> >>
> >>I'll remove the upstream remove-jquery branch for now. I'd suggest
> >>we just
> >> continue to knock them off one JS file at a time, but I'll leave
> >> this with you two for now so I don't tread on your toes.
> >>
> >>Regards,
> >>Ben
> >>
> >>On Sun, 15 Aug 2021, Ben Sturmfels wrote:
> >>  
> >>> Welcome André! I was worried for a minute that we'd confused
> >>> things and there was actually a framework called "Vanilla" when I
> >>> found the below site but it's actually a a hilarious parody site
> >>> where the download is zero bytes:
> >>>
> >>> http://vanilla-js.com/
> >>>
> >>> The mediagoblin code is at:
> >>>
> >>> https://git.savannah.gnu.org/git/mediagoblin.git
> >>>
> >>> I did start on a "remove-jquery" branch, but you might want to
> >>> coordinate with jgart about what is best to work on.
> >>>
> >>> On Sat, 14 Aug 2021, André Jaenisch wrote:
> >>>  
> >>>> Hey there,
> >>>>
> >>>> silent reader for years and Frontend engineer by trade here.
> >>>>
> >>>> Porting jQuery to Vanilla?
> >>>> Where can I find the code?
> >>>> (Last thing I recalled was GNU Savannah something).
> >>>>
> >>>> What's to consider regarding reproducibility?
> >>>> (Happy to continue off-list)
> >>>>
> >>>>
> >>>> André