[Mldonkey-users] [patch #4477] win: prevented some compiler warnings (os_stubs_c.c gdstubs.c)

[Schlumpf]

Follow-up Comment #2, patch #4477 (project mldonkey):

>It would be better if you returned 0 instead of '/0' since the
>expected return type is an int64.

yep i agree with you, so this should be changed.

"ret" is declared as long, INVALID_SET_FILE_POINTER is defined as an
DWORD(unsigned long) in winbase.h
This comparison is then "signed long == unsigned long" thats the reason for
the compiler Warning "src/config/mingw/os_stubs_c.c:111: warning: comparison
between signed and unsigned"

so its required to change the declaration of "ret" to an DWORD or make an
casting to an DWORD (unsigned long), it doesen`t make any different to me
what we use, so you can pick out one of the possibilities ;)

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?func=detailitem&item_id=4477>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/