[Mldonkey-users] [patch #6956] can't download torrent files with no 'announce' field

[spiralvoice]

URL:
  <http://savannah.nongnu.org/patch/?6956>

                 Summary: can't download torrent files with no 'announce'
field
                 Project: mldonkey, a multi-networks file-sharing client
            Submitted by: user
            Submitted on: Do 22 Okt 2009 21:31:12 CEST
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: None
        Operating System: None
         Binaries Origin: None
                CPU type: None

    _______________________________________________________

Details:

There are many torrent files now that only contain 'announce-list', not
'announce' field (most created with new uTorrent versions).
Mldonkey handles multiple trackers nice, but 
one internal assertion fails on such files, preventing
download.

3.0.0-3 from squeeze is also affected.

Here is a working patch for this, and a couple of test torrents.


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Di 09 Mai 2006 19:37:24 CEST  By: spiralvoice <spiralvoice>
test

-------------------------------------------------------
Date: So 07 Aug 2005 19:53:07 CEST  By: spiralvoice <spiralvoice>
http://forum.emule-project.net/index.php?act=ST&f=6&t=75045&hl=&view=findpost&p=523099

-------------------------------------------------------
Date: Mi 25 Mai 2005 23:52:03 CEST  By: spiralvoice <spiralvoice>
donkeyInteractive.ml
let forget_search s =
  if !xs_last_search = s.search_num then begin
      xs_last_search := (-1);
      xs_servers_list := [];
    end;

donkeyUdp.ml
  | Udp.QueryReplyUdpReq t ->
      (* lprintf "Received file by UDP\n"; *)
      if !xs_last_search >= 0 then

So it seems MLDonkey really can currently handle only one UDP
search at a time. Is there a way to distinguish UDP search
results if they were originated by different searches?

On possible solution would be to block the start of a new search
until the previous one has finished. Other solutions?

-------------------------------------------------------
Date: Mi 25 Mai 2005 19:42:47 CEST  By: z <zet>
This is not overnet related.

1. When starting a new search, donkeySearch.send_search automatically calls
DonkeyUdp.make_xs

2. DonkeyUdp.make_xs sets !xs_last_search to this new search number (
xs_last_search := ss.search_num )

3. All future UDP search replies that are received are attached to this new
search even if the results are not related (they are related to a previous
search) 

donkeyUdp.Udp.QueryReplyUdpReq -> 
... let ss = search_find !xs_last_search ....





-------------------------------------------------------
Date: Do 19 Mai 2005 15:59:52 CEST  By: spiralvoice <spiralvoice>
Try turning off Overnet. Does the bug still exist then?

-------------------------------------------------------
Date: Di 12 Apr 2005 18:21:04 CEST  By: z <zet>
MLNet 2.5-30-4: Multi-Network p2p client (Global Shares Gnutella G2 Fasttrack
FileTP BitTorrent Donkey) 

Searching 2 queries
[Forget] [1    ]CONTAINS[car]  -77 (found 72)
[Forget] [2    ]CONTAINS[3il3i3li3]  -204 (found 179)

MLNet 2.5-30ac_r264M

Searching 4 queries
[Forget] [1    ]CONTAINS[car]  -156 (found 851)
[Forget] [2    ]CONTAINS[ilili3jli3j3il3]  done (found 0)
[Forget] [3    ]CONTAINS[bike]  3 (found 236)
[Forget] [4    ]CONTAINS[bike3i23ild]  -262 (found 179)

Timing matters I guess.  I don't see any patch that addresses this.  

-------------------------------------------------------
Date: Di 12 Apr 2005 13:11:13 CEST  By: spiralvoice <spiralvoice>
Don´t have this bug on 2-5-30-4, please try that version.

[3    ]CONTAINS[car]  done (found 1076)
[4    ]CONTAINS[jkjkjjjkkjj]  done (found 0)
[5    ]CONTAINS[madonna]  done (found 1050)
[6    ]CONTAINS[tvrioeufeonitujifz]  done (found 0)
[7    ]CONTAINS[york]  done (found 943)
[8    ]CONTAINS[dcvmtiovnutzvrt]  done (found 0)
[9    ]CONTAINS[hamburg]  done (found 65)
[10   ]CONTAINS[vtzivgutzovgnuz]  done (found 0)
[11   ]CONTAINS[car]  done (found 876)
[12   ]CONTAINS[lwielielieie]  done (found 0)


-------------------------------------------------------
Date: Di 13 Apr 2004 17:05:43 CEST  By: Anonymous
I'm noticing the same misbehavior with 2.5.16

It happens when search queries are made between short time intervals (< 5
seconds)



-------------------------------------------------------
Date: Di 23 Mär 2004 04:19:26 CET  By: z <zet>
MLNet 2.5-17: Multi-Network p2p client (Global Shares Direct Connect Open
Napster Gnutella G2 Fasttrack FileTP BitTorrent Donkey Soulseek) 

set filter_search_delay 1

<save & restart core>

Searching 2 queries
[Forget] [12   ]CONTAINS[car]  -275 (found 627)
[Forget] [13   ]CONTAINS[ilsdifiasldfasdf]  -259 (found 188)




-------------------------------------------------------
Date: Di 23 Mär 2004 02:52:05 CET  By: spiralvoice <spiralvoice>
Maybe this has something to do with filter_search_delay which defaults to 5
seconds, please lower that value to 1 and retry.

-------------------------------------------------------
Date: Fr 05 Mär 2004 04:40:55 CET  By: z <zet>
I'm only connected to edonkey servers (connected to 4 of 216 at the moment).

Using the web interface, I just type "s car" and immediately "s <garbage>" in
the input line.

Searching 2 queries
[Forget] [1    ]CONTAINS[car]  -193 (found 856)
[Forget] [2    ]CONTAINS[3i3lilsidff]  -188 (found 142)

I see that your queries are "done"... mine are not.



-------------------------------------------------------
Date: Fr 05 Mär 2004 01:57:07 CET  By: spiralvoice <spiralvoice>
Can´t confirm that one here:

MLNet 2.5-12: Multi-Network p2p client (Global Shares Open Napster Gnutella
G2 Fasttrack FileTP BitTorrent Donkey Soulseek)

Searching 2 queries
[Forget] [1    ]CONTAINS[car]  done (found 641)
[Forget] [2    ]CONTAINS[lwielielieie]  done (found 0)

To how many edonkey servers are you connected to?
Do these search results also include other networks than edonkey?
Here I am connected to 3 servers and I use only Edonkey/Overnet.

-------------------------------------------------------
Date: Fr 05 Mär 2004 01:14:27 CET  By: z <zet>
This is still a problem with 2.5.12. From web interface:

MLNet 2.5-12: Multi-Network p2p client (Global Shares Direct Connect Open
Napster Gnutella G2 Fasttrack FileTP BitTorrent Donkey Soulseek) 

Searching 2 queries
[Forget] [4    ]CONTAINS[car]  -368 (found 1000)
[Forget] [5    ]CONTAINS[lwielielieie]  -120 (found 94)



-------------------------------------------------------
Date: Mi 25 Feb 2004 02:07:56 CET   By: spiralvoice <spiralvoice>
This was done with 2.5-12:
> vs
Searching 2 queries
[5    ]CONTAINS[car]  done (found 803)
[6    ]CONTAINS[kdkdkdkdkd]  done (found 0)
also with Newgui and Sancho. I saw this bug before as stated
but it seems to be solved quietly;-)

-------------------------------------------------------
Date: Di 23 Dez 2003 10:48:20 CET   By: spiralvoice <spiralvoice>
same here using newgui

-------------------------------------------------------
Date: Di 23 Dez 2003 07:04:56 CET   By: Anonymous
2.5.4+2

Search results for one search appear in the results of another.  Simple
example:

Search for something very popular. "s car"
Immediately search for something impossible "s liselirijewi"

The results for "liselirijewi" will contain some of the results for "car"...


Donkey/BT are the only networks enabled.








    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6956>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/