Re: Memory totals not adding up

[Martin Pala]

Thanks Darhl :)

We have added the patch to the source repository, the fix will be part of next 
release. I have tested  it with IE, Safari, Chrome, Firefox and the page 
displayes fine.

Regarding the diff … the reason why it didn't displayed only the changes was, 
that the cervlet_fixed.c had Windows-like line terminator (CRLF), whereas the 
original source code is unix-like LF. When converted the windows format to unix 
the "diff -Naur src/http/cervlet.c cervlet_fixed.c"  shows the differences 
correctly.

Best regards,
Martin


On Sep 14, 2011, at 4:45 PM, Darhl Thomason wrote:

> Martin,
> 
> Everything looks good, but I found some HTML formatting issues in the
> current version.  I updated cervlet.c and recompiled and it's working
> as expected, but I don't know how to create a patch to send in.  I've
> attached the cervlet_fixed.c for your review.
> 
> The HTML formatting issues were:
> 1.  First column (left most) in main screen was centering when viewed in IE.
>  - fixed by changing the <td> to <td align='left'>
> 2.  When I examined the page source I noticed there was an extra
> '</tr>' being generated for the 'Services' table.
>  - fixed by removing the extra </tr>
> 
> Both of these items are fixed in the attached cervlet_fixed.c.
> 
> I looked at using diff to create the patch file, but it added every
> line into the patch file I was trying to generate and I knew that
> wasn't right.
> 
> Anyway, I hope my fixes can be added if you find them appropriate.
> 
> Thanks again!!
> 
> Darhl
> 
> --------------------------------------------------------------------------------
> From:  Darhl Thomason
> Subject:  Re: Memory totals not adding up
> Date:  Tue, 13 Sep 2011 18:02:22 -0700
> 
> I got it Martin, it's reporting properly now!
> 
> Thanks again for your help and the quick patches!
> 
> Darhl
> 
> On Tue, Sep 13, 2011 at 5:54 PM, Darhl Thomason <address@hidden> wrote:
>> Let me try this and see how it goes. Â It's a good learning exercise
>> for me since I've never patch source before.
>> 
>> 
>> On Tue, Sep 13, 2011 at 2:17 PM, Martin Pala <address@hidden> wrote:
>>> … if you prefer the binary build (such as monit-5.3-linux-x64.tar.gz), i 
>>> can
>>> prepare binary fix as well - let me know which platform you need (such as
>>> the linux-x64)
>>> 
>>> 
>>> On Sep 13, 2011, at 11:14 PM, Martin Pala wrote:
>>> 
>>>> You need to recompile to apply the patch:
>>>> 
>>>> Â  Â  Â  wget http://www.mmonit.com/monit/dist/monit-5.3.tar.gz
>>>> Â  Â  Â  tar -xzf monit-5.3.tar.gz
>>>> Â  Â  Â  cd monit-5.3
>>>> Â  Â  Â  patch -p0 < mem_percent.patch
>>>> Â  Â  Â  ./configure
>>>> Â  Â  Â  make
>>>> Â  Â  Â  make install
>>>> 
>>>> Best regards,
>>>> Martin
> <cervlet_fixed.c>--
> To unsubscribe:
> https://lists.nongnu.org/mailman/listinfo/monit-general