# # patch "ChangeLog" # from [3763f9125c4feb2426ed99b5fa4b225bf2517c31] # to [70bc03ac0ffeb333525af034256a6f4f52ada0e0] # # patch "HACKING" # from [7058afa41b4a62f2c04b67fd846b413de0ba182d] # to [c30170f75719369e7d173333c2d19df050016754] # # patch "tests/README" # from [b784213ac7f9fd2090fdf3209083be4f865a6ce7] # to [ccb7c4ae3649d32872d2c6f7db03ef6bec2ba254] # ======================================================================== --- ChangeLog 3763f9125c4feb2426ed99b5fa4b225bf2517c31 +++ ChangeLog 70bc03ac0ffeb333525af034256a6f4f52ada0e0 @@ -1,3 +1,9 @@ +2005-11-28 Matthew Gregan + + * HACKING: Make a note of the fact that we kill 'monotone serve' + processes with a SIGSEGV. + * tests/README: Minor cleanup, mention SIGSEGV thing here too. + 2005-11-27 Matthew Gregan * netxx/address.cxx (parse_uri): Reset URI parser state after ======================================================================== --- HACKING 7058afa41b4a62f2c04b67fd846b413de0ba182d +++ HACKING c30170f75719369e7d173333c2d19df050016754 @@ -115,7 +115,13 @@ test case exists, it is strongly recommended to write a test case before attempting to fix the bug. +When looking at test results or debugging tests, don't immediately panic if you +notice monotone processes being killed by a SIGSEGV. We use SIGSEGV to +terminate 'monotone serve' processes (only) to ensure the error exit paths are +tested. Other than these 'monotone serve' processes, any SIGSEGVs occurring +during the tests is very likely a bug. + Reporting errors to the user ---------------------------- ======================================================================== --- tests/README b784213ac7f9fd2090fdf3209083be4f865a6ce7 +++ tests/README ccb7c4ae3649d32872d2c6f7db03ef6bec2ba254 @@ -14,17 +14,19 @@ - option -v will show the command outputs - option -d will keep the testsuite.dir files for post-test debugging - option -h is your friend :) +- don't panic if you see 'monotone serve' processes terminating with a SIGSEGV + during tests--we kill server processes with a SIGSEGV to get better code coverage. Creating tests: --------------- - Copy and paste is your friend :) - TODO: need more here... - Remember to add a line at the end of testsuite.at +- Use CANONICALISE(file) or CHECK_SAME_CANONICALISED_STDOUT(file, cmd) so that + EOLs are handled correctly (think CR+LF on Win32) - -Template for a test (name t_.at -------------------- - +Template for a test (name tests/t_.at: +------------------------------------------------ AT_SETUP([brief test description goes here]) MONOTONE_SETUP @@ -47,3 +49,4 @@ ... AT_CLEANUP (END) +