[Monotone-devel] crash when server not available

[Tom Tromey]

I tried to fetch today and got the appended.

I think this is a bit too voluminous for a "normal error".
I'd prefer to see it print a single error message and then continue
trying the next URL.

Also, the message looks a bit strange... see the lines starting "'TTP".
I wonder if that is a boost formatter bug.  The code looks ok to me.
Removing the single quotes seems to "fix" the problem.

# Old manifest: 2793fc8add23cae03addc31bd980b881858c8cd2
# New manifest: b69b2226ba88ac67597975086b08c46af3fc4125
# Summary of changes:
#   patch http_tasks.cc 3878db850fdc81a3fcfbe5b50f46ee4ba065f0c1 -> 
a36b97e0f34fdcfde1a8693ddb01228f8cd0ced6
--- http_tasks.cc
+++ http_tasks.cc
@@ -171,7 +171,7 @@
        if (bytes == 1 || tmp.empty() || tmp == "\r") 
          in_headers = false;
        else
-         L(F("HTTP <- header %d bytes: '%s'\n") % bytes % tmp);
+         L(F("HTTP <- header %d bytes: %s\n") % bytes % tmp);
       }
   }
 


Tom


fleche. monotone fetch
monotone: fetching from all known URLs
monotone: fetching packets from group monotone at 
http://www.off.net/monotone/depot.cgi
options path is MT/options
opening rcfile '/home/tromey/.monotonerc' ... ok
executing fetch command
lua isfunction() failed in get_fn
fetching from all known URLs
db.fetch("SELECT url, groupname FROM sequence_numbers ")
fetching packets from group monotone at http://www.off.net/monotone/depot.cgi
db.fetch("SELECT major, minor FROM sequence_numbers WHERE url = 
'http://www.off.net/monotone/depot.cgi' AND groupname = 'monotone' LIMIT 1")
resolved 'www.off.net' as '66.246.133.2'
connecting to port number 80
HTTP -> 'GET /monotone/depot.cgi?q=since&group=monotone&maj=0&min=1361 
HTTP/1.0'HTTP -> 'Host: www.off.net'
'TTP <- header 33 bytes: 'HTTP/1.0 503 Service Unavailable
'TTP <- header 24 bytes: 'Cache-Control: no-cache
'TTP <- header 17 bytes: 'Pragma: no-cache
                                                                                
*** Error: std::out_of_range: basic_string::at
                                                                                
**** error return code 205
**********  errors detected; see standard output for details  ***********