monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Monotone-devel] Re: line endings with 0.31


From: Graydon Hoare
Subject: [Monotone-devel] Re: line endings with 0.31
Date: Mon, 20 Nov 2006 11:31:02 -0800
User-agent: Thunderbird 1.5.0.8 (X11/20061025)

Nathaniel Smith wrote:

The get_linesep_conv hook is passed the filename, it can do whatever
it likes with it.  E.g.,
  function get_linesep_conv(filename)
    if regex.search("\\.jpe?g$", filename) then
      return {"LF", "LF"}
    end
    return {"LF", "CRLF"}
  end

Woah! Did we really leave it like this? That's terrible. We added an attribute to files called mtn:manual_merge that controls whether the merger believes it can do line-merging on the file or whether the file should be treated as binary. Can't we assume that mtn:manual_merge implies "don't do the linesep / charset conversion on i/o"? Or can we rephrase the attribute as mtn:blob, or such? Users should not have to muck about with this linesep conversion function stuff, if possible.

-graydon





reply via email to

[Prev in Thread] Current Thread [Next in Thread]