[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Monotone-devel] [PATCH] Re: on the semantics of 'mtn mv'
From: |
Ben Walton |
Subject: |
[Monotone-devel] [PATCH] Re: on the semantics of 'mtn mv' |
Date: |
Mon, 30 Jul 2007 10:56:33 -0400 |
Ok, I've implemented a 'fix' for this behaviour. I believe that mtn
rename is now more consistent with mv(1). The attached patch includes
updates for the code, docs and tests. The diff is against revision
b78672c7f625a5875db79b4a27567e751e1103bc
The log message I used locally is:
* Corrected the way mtn rename works such that it is more consistent with the
way mv(1) works. Eg: if moving to a directory the source item
is nested in
the directory and the directory added if necessary (assuming other checks
pass).
As an aside (and I haven't tested at all), were keys and permissions
that existed on venge.net moved over directly to monotone.ca?
Thanks
-Ben
On 7/25/07, Nathaniel Smith <address@hidden> wrote:
> On Thu, Jul 26, 2007 at 09:18:32AM +1000, William Uther wrote:
> > I agree that things seems inconsistent given that example. I'm not
> > sure if we want case 1 to behave like case 2; I'd go with the other
> > way around. I'm not sure I like this 'magic add' semantics (but I'm
> > not horribly opposed to it either). Case 4 should return a user error.
>
> I know I'm usually the one haranguing against magic, but I'm actually
> pro- magic add. The reason being, in this case the user's intentions
> are totally clear to the program, and the program's results are quite
> obvious to the user. We all know the "stupid program, if you knew
> what I wanted then why didn't you do it?" feeling, and it's nice not
> to invoke it more than absolutely necessary. (It is, of course,
> absolutely necessary in all sorts of cases where the user's request
> *is* ambiguous, no matter what they think...)
>
> -- Nathaniel
>
> --
> - Don't let your informants burn anything.
> - Don't grow old.
> - Be good grad students.
> -- advice of Murray B. Emeneau on the occasion of his 100th birthday
>
>
> _______________________________________________
> Monotone-devel mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/monotone-devel
>
--
---------------------------------------------------------------------------------------------------------------------------
Ben Walton <address@hidden>
When one person suffers from a delusion, it is called insanity. When
many people suffer from a delusion it is called Religion.
Robert M. Pirsig, Zen and the Art of Motorcycle Maintenance
---------------------------------------------------------------------------------------------------------------------------
fixed-rename.patch
Description: Text Data