[Monotone-devel] Re: Please review nvm.deregexp

[Zack Weinberg]

I have landed this branch now
zw

On 9/28/07, Zack Weinberg <address@hidden> wrote:
> I'm just about done with the project of removing as many internal uses
> of regular expressions from the 'mtn' binary as is practical.  I would
> appreciate review of net.venge.monotone.deregexp.  The files most
> substantially changed are uri.cc, packet.cc, and glob.cc.  I'm very
> confident in the changes to uri.cc, which is quite simple; less so the
> other two.  Especially, while I think that there's no way to get the
> new glob implementation to go into unbounded recursion, I can't quite
> prove it, and the matching unit tests are somewhat feeble.
>
> Remaining uses of regular expressions are for the diff -p feature, in
> lua hooks, and in the testsuite.  I don't think it's practical to
> eliminate hardly any of these (the biggest remaining one that could go
> is .mtn-ignore, and that would be a major flag day).  Therefore, my
> plan is to work on merging the .experiment.pcre branch next; but I'd
> like to get this laid down first.
>
> zw
>