Re: [Monotone-devel] special files

[William Uther]

Hi,
  I added that code fairly recently.  Before that special files used  
to bomb out even more than they
currently do.  My guess is that you're in the walk_tree_recursive() - 
> read_directory() calling chain.  At the moment this will bomb on  
all special files because there isn't code in the tree_walker class  
to pass information on special files back to the caller.

  The simplest thing to do would be to fix the error message:  When  
the special_files vector in read_directory() is not empty then list  
the files as well as complaining about them.

  The next biggest change would be to make read_directory() return a  
list of special files as well as normal files, then make the  
tree_walker class handle them.  Then you'd have to go through all the  
places that call walk_tree_recursive() and individually decide how  
they should handle special files.

  Not rocket science, but I don't have time right now.

Be well,

Will       :-}

On 23/10/2007, at 6:55 PM, Lapo Luchini wrote:

> % context 351 file_io.cc
>    348    vector<path_component> special_files;
>    349    fill_pc_vec ff(files), df(dirs), sf(special_files);
>    350    do_read_directory(path.as_external(), ff, df, sf);
>    351    E(special_files.empty(), F("cannot handle special files  
> in dir
> '%s'") % path);
>    352  }
>    353
>    354  // This function can only be called once per run.
>
> It happened I got a "cannot handle special files in dir '.'" while
> versioning my home directory.
> I (manually) found the special file (which was some kind of socket
> created by rxvt-unicode), but I wonder: is it really necessary to stop
> mtn from executing at all simply because there is a special file in  
> the
> workspace?
> Couldn't it simply be skipped?
>
> I mean: it was not in the roster at all, but I couldn't even execute
> "mtn st" correctly... and the error message didn't tell me the name of
> the problematic file either =)
>
> Is there a special reason for that I don't see, or should I patch it
> somehow?
>
>     Lapo
>
>
>
> _______________________________________________
> Monotone-devel mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/monotone-devel