[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] [PATCH] fix use of hostname from parsed uri
From: |
Zack Weinberg |
Subject: |
Re: [Monotone-devel] [PATCH] fix use of hostname from parsed uri |
Date: |
Fri, 26 Sep 2008 17:27:15 -0700 |
On Fri, Sep 26, 2008 at 4:41 PM, Roland McGrath <address@hidden> wrote:
>> > mtn sync mtn://server/foobar
>>
>> ... huh?
...
> The fix that allows "mtn://server" to work also allows "mtn://server/name"
> so that the rest of the story can be done quite nicely just with more minor
> hacking on usher.
Oh, I see. I thought you might be saying that your patch somehow
caused "mtn://server" to get rewritten to "mtn://server/name" which
didn't make any sense.
>> Is it possible you could write a test case or two for this bug?
>
> The test is any push/pull/sync operation using "mtn://server" instead of
> "server" (or "mtn://server:port/" instead of "server:port") as the ADDRESS
> parameter.
I understood this; I was asking you to write an automated test that
could be added to the test suite, to ensure that it doesn't get broken
in the future.
zw