Re: [Monotone-devel] heads up: file system changes

[Stephen Leake]

Zack Weinberg <address@hidden> writes:

> I've just pushed a bunch of cleanups to the file system access code.
> These should catch more cases where we needed to be skipping invalid
> paths, and improve the diagnostics for them, too.  However, there is a
> very good chance that I have completely broken win32/fs.cc.  For this
> I apologize, but must ask for help from Windows people in testing and
> fixing.  (In particular, it might be that we really should not try to
> use SHFileOperation for recursive delete.)

I fixed a couple compiler warnings in win32/fs.cc; you were modifying
a constant string (not committed yet). But now _every_ test is
failing; "error creating test directory".

I'll look at it more later, but I suspect the simplest fix is to just
move the original do_remove_recursive into win32/fs.cc.

What is the rationale for making this platform-specific? It would help
if that rationale was documented in the code.

-- 
-- Stephe