[Monotone-devel] Re: 0.48 rants

[Marcin W. Dąbrowski]

Hi.

2¢ from humble user.

> From: Lapo Luchini <address@hidden>
> I like it quite a bit using EDITOR="nano +14"...
> I was thinking, should be the default hook that adds "+14" to
> the editor name? (maybe recognizing it in a short list of ones
> that *do* support that +N thing I wasn't aware of)
> 
> From: Ethan Blanton <address@hidden>
> I agree with the various comments running around that +14 (or
> whatever) is easy enough.

Long story short, on Windows, I ended changing the `edit_comment`
hook to include '+14', like that:

    if (not string.find(exe, "[^%w_.+-:\\]")) then
       -- safe to call spawn directly
-      if (execute(exe, tname) ~= 0) then
+      if (execute(exe, '+14', tname) ~= 0) then

I'd love to have a hook working the way Lapo specified, although
it could be tricky to guess the editor name. On my system it is:

C:\>set|grep "EDITOR\|VISUAL"
EDITOR=C:\vim\vim72\vim.exe
VISUAL=C:\vim\vim72\gvim.exe

But the best solution to date is:

>     a) An RFC-822ish header block followed by one blank line,
>        followed by the commit message, followed by a magic
>        separator and the boilerplate text which I can then
>        safely ignore. ;-)
>
>     b) The commit message leading things off, followed by
>        a magic separator and the metadata, followed by
>        boilerplate I can safely ignore.

I like the idea. I tried to see how it would look like, and… how
about that? Not exactly in line with the ideas above, but fairly
linear and clear — at least for me. :)

#v+


MTN: Enter commit message on the first line above.
MTN: Lines beginning with 'MTN:' are removed.
MTN: Leave message empty to abort commit.
MTN: ------------------------------------------------------------
MTN: Commit Metadata
MTN: Author, Date and Branch may be modified as required.

Revision: d8f494e0ad3e0ee03bcb98e103acdd9f03c769ff
Parent:   06b854ae2105db88b2bfe7fda20933e448f6f2b6
Author:   address@hidden
Date:     2010-07-19T18:48:58
Branch:   master

MTN: ------------------------------------------------------------
MTN: Changes list, will be included in log.

Changes against parent 06b854ae2105db88b2bfe7fda20933e448f6f2b6

  patched  x

#v-

Sincerely,
-- 
Marcin W. Dąbrowski