Re: [Monotone-devel] Unit test fail with SQLite 3.7

[Timothy Brownawell]

On 07/31/2010 08:14 PM, Francis Russell wrote:
> Hi all,
>
> a Debian archive rebuild failed to rebuild monotone 0.48 from source.
> The following test failed:
>
> 235 fail_cleanly_on_unreadable_db                 FAIL (line 51) 0:01,
> 0:00 on CPU
>
> The full log is here:
> http://people.debian.org/~lucas/logs/2010/07/31/monotone_0.48-1_lsid64.buildlog
>
> Based on Thomas Keller's summary of the test
> (http://lists.nongnu.org/archive/html/monotone-debian/2010-07/msg00020.html),
> it looks like SQLite 3.7 is the culprit. As far as I can tell, it isn't
> creating a journal file, so the expected failure to migrate never happens.

It looks like it only creates journal files while there are uncommitted 
changes. So an empty 'db migrate' doesn't create a journal, 'mtn serve' 
only has a journal file while there are active write connections 
(killing an idle server doesn't leave a stale -journal file, yay), etc.


----------------------------------------------------------------------
Revision: 78f4db157a353de19b33df875959efc2492812b4
Parent:   c36b63fe53580cdf51cd5c6afa42fc4a30a1d095
Author:   Timothy Brownawell  <address@hidden>
Date:     07/27/2010 09:28:25 PM
Branch:   net.venge.monotone

Changelog:

SQLite 3.7 is less eager about creting journal files; in particular a
do-nothing 'db migrate' doesn't create one. So don't require that
'db migrate' fail if the database directory isn't writeable.

Changes against parent c36b63fe53580cdf51cd5c6afa42fc4a30a1d095

  patched  tests/fail_cleanly_on_unreadable_db/__driver__.lua

============================================================
--- tests/fail_cleanly_on_unreadable_db/__driver__.lua 
1ec557d1aef9eac9ee53a22d07f4ba0f3456da5e
+++ tests/fail_cleanly_on_unreadable_db/__driver__.lua 
8875c78a070bef87904bb840ed3cffa0acba4399
@@ -48,7 +48,6 @@ check(mtn("--db=subdir/foo.db", "db", "v
 check(mtn("--db=subdir/foo.db", "ls", "branches"), 0, false, false)
 check(mtn("--db=subdir/foo.db", "db", "info"), 0, false, false)
 check(mtn("--db=subdir/foo.db", "db", "version"), 0, false, false)
-check(mtn("--db=subdir/foo.db", "db", "migrate"), 1, false, false)
 check(mtn("--db=subdir/bar.db", "db", "load"), 1, false, false)
 check(mtn("--db=subdir/baz.db", "db", "init"), 1, false, false)
 check({"chmod", "a+w", "subdir"})


--
Timothy

Free public monotone hosting: http://mtn-host.prjek.net