Re: [Monotone-devel] Please review nvm.automate_get_roster

[Stephen Leake]

Thomas Keller <address@hidden> writes:

> Please review the above branch. The branch name has not so much in
> common with the actual implementation anymore, though:
>
> * a new file_sizes table has been added which records the size
>   in bytes of individual files
> * two new automate commands have been added, get_file_size returns
>   a single recorded file size, get_extended_manifest_of returns
>   a format similar to the current roster format, but without the
>   local node ids. Additionally, the format prints out the recorded
>   file size for each file node
> * migration code and tests have been added, some parts of the migration
>   code were refactored / expanded
> * documentation and NEWS / UPGRADE was updated as well

The code and documentation look ok.

What is the rationale for caching file sizes, as opposed to computing
them when needed?

When are they needed?

We should have a standard place to document rationales like this.

-- 
-- Stephe